Skip to content

fix(settings): prevent j/k navigation keys from intercepting edit buffer input #21865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Adib234 merged 6 commits into from
Mar 13, 2026
+50 −3
Merged

fix(settings): prevent j/k navigation keys from intercepting edit buffer input #21865

Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
938477b
fix(settings): prevent j/k navigation keys from intercepting edit buf…
student-ankitpandit Mar 10, 2026
98b5743
fix(settings): replace focusSession with effectiveFocusSession
student-ankitpandit Mar 10, 2026
651fde9
Merge branch 'main' into fix/settings-string-input-vim-keys
student-ankitpandit Mar 10, 2026
fe55875
Merge branch 'main' into fix/settings-string-input-vim-keys
student-ankitpandit Mar 10, 2026
848d134
test(settings): add regression test for j/k input in edit buffer
student-ankitpandit Mar 11, 2026
73196a9
fix: code consistency
student-ankitpandit Mar 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions packages/cli/src/ui/components/shared/BaseSettingsDialog.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -325,13 +325,18 @@ export function BaseSettingsDialog({
return;
}

// Up/Down in edit mode - commit and navigate
if (keyMatchers[Command.DIALOG_NAVIGATION_UP](key)) {
// Up/Down in edit mode - commit and navigate.
// Only trigger on non-insertable keys (arrow keys) so that typing
// j/k characters into the edit buffer is not intercepted.
if (keyMatchers[Command.DIALOG_NAVIGATION_UP](key) && !key.insertable) {
commitEdit();
moveUp();
return;
}
if (keyMatchers[Command.DIALOG_NAVIGATION_DOWN](key)) {
if (
keyMatchers[Command.DIALOG_NAVIGATION_DOWN](key) &&
!key.insertable
) {
commitEdit();
moveDown();
return;
Expand Down