fix(core): increase A2A agent timeout to 30 minutes#21028
Conversation
|
Hi @adamfweidman, thank you so much for your contribution to Gemini CLI! We really appreciate the time and effort you've put into this. We're making some updates to our contribution process to improve how we track and review changes. Please take a moment to review our recent discussion post: Improving Our Contribution Process & Introducing New Guidelines. Key Update: Starting January 26, 2026, the Gemini CLI project will require all pull requests to be associated with an existing issue. Any pull requests not linked to an issue by that date will be automatically closed. Thank you for your understanding and for being a part of our community! |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses an issue where long-running remote agents were timing out due to a default 5-minute fetch limit. By implementing a dedicated dispatcher with an extended 30-minute timeout specifically for Agent-to-Agent communications, it ensures these agents can complete their tasks without interruption, while preserving the existing timeout behavior for all other fetch operations. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request increases the timeout for A2A client requests to 30 minutes to support long-running agents. The implementation correctly creates a custom undici dispatcher with the longer timeout and uses it for A2A fetch calls without affecting the global fetch timeout. My review includes one suggestion to improve type safety and code clarity around the custom fetch implementation by using // @ts-expect-error instead of a misleading type assertion.
|
Size Change: +471 B (0%) Total Size: 25.9 MB ℹ️ View Unchanged
|
ab25dab to
779c6e8
Compare
| } | ||
|
|
||
| let fetchImpl: typeof fetch = fetch; | ||
| let fetchImpl: typeof fetch = a2aFetch; |
There was a problem hiding this comment.
can you add a test that verifies that the timeout passed in is actually respected? particularly given we ware passing it in getting around the type system.
Summary
Increases the timeout for A2A (Agent-to-Agent) client requests to 30 minutes. This ensures that long-running remote agents, like Deep Research, can complete their tasks without being cut off by the default 5-minute timeout.
Details
UndiciAgent(dispatcher) withheadersTimeoutandbodyTimeoutset to 30 minutes (1,800,000ms).fetchcalls inA2AClientManagerwith a customa2aFetchthat uses this dispatcher.Related Issues
Fixes #21027
How to Validate
Pre-Merge Checklist