-
Notifications
You must be signed in to change notification settings - Fork 13k
fix(auth): update terminology to 'sign in' and 'sign out' #20892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 25 commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
811b5b9
fix(auth): update terminology from 'Login with Google' to 'Sign in wi…
clocky 6b72773
fix(auth): update terminology from 'login' to 'sign in'
clocky 7832d3b
fix(auth): update terminology from 'Logged in' to 'Signed in'
clocky 6b79682
fix(auth): update terminology from 'Logged in' to 'Signed in' in Stat…
clocky ebcc790
fix(auth): update terminology from 'Logged in' to 'Signed in' in User…
clocky 184cf10
fix(auth): update terminology from 'Logged in' to 'Signed in' in Mode…
clocky 8c2c590
fix(auth): update terminology from 'Waiting for auth...' to 'Waiting …
clocky 3c6ee36
fix(auth): update terminology from 'logged out' to 'signed out' in Lo…
clocky 4a18912
fix(auth): update terminology from 'login' to 'sign in' in authentica…
clocky e58ed4f
fix(auth): update capitalization in waiting message in ValidationDial…
clocky 3197467
fix(auth): update terminology from 'logged in' to 'signed in' in Logi…
clocky c8ae6d3
fix(auth): update terminology from 'login' to 'signin' and 'logout' t…
clocky efc7d9b
fix(auth): update terminology from 'login' to 'sign in' in README.md
clocky f66f1dc
fix(auth): update terminology from 'login' to 'sign in' across docume…
clocky cf28204
test(cli): update auth terminology tests and snapshots
clocky 995bb83
fix(auth): update error message for failed authentication test
clocky 4cd31f6
fix(auth): add alternative names for signin and signout commands
clocky 5e7a31e
test(cli): verify signin/signout altNames in authCommand tests
clocky d5a61f9
Merge main into fix/auth-strings and resolve conflicts in UserIdentity
clocky c97c38a
Merge branch 'main' into fix/auth-strings
clocky 6f45291
Merge branch 'main' into fix/auth-strings
clocky 590d9b5
Merge branch 'main' into fix/auth-strings
clocky f663866
Merge branch 'main' into fix/auth-strings
clocky d6af6eb
Merge branch 'main' into fix/auth-strings
jacob314 207da90
Merge branch 'main' into fix/auth-strings
clocky 6e5d68c
fix(ui): update user identity description for clarity
clocky 49bf355
test(cli): update snapshot for sign-in terminology change
clocky 118b454
Merge branch 'main' into fix/auth-strings
clocky 700512c
Merge branch 'main' into fix/auth-strings
clocky File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -36,7 +36,7 @@ describe('AboutBox', () => { | |
| expect(output).toContain('gemini-pro'); | ||
| expect(output).toContain('default'); | ||
| expect(output).toContain('macOS'); | ||
| expect(output).toContain('Logged in with Google'); | ||
| expect(output).toContain('Signed in with Google'); | ||
| unmount(); | ||
| }); | ||
|
|
||
|
|
@@ -63,7 +63,7 @@ describe('AboutBox', () => { | |
| ); | ||
| await waitUntilReady(); | ||
| const output = lastFrame(); | ||
| expect(output).toContain('Logged in with Google ([email protected])'); | ||
| expect(output).toContain('Signed in with Google ([email protected])'); | ||
| unmount(); | ||
| }); | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.