Skip to content

Plumb the maxAttempts setting through Config args #20239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kevinjwang1 merged 10 commits into from
Feb 25, 2026
Merged

Plumb the maxAttempts setting through Config args #20239

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
92dc765
Fix retries
kevinjwang1 Feb 24, 2026
4a5e7e6
Merge branch 'main' into testRetries
kevinjwang1 Feb 24, 2026
0a24e45
Remove maxAttempts config from the dialog box
kevinjwang1 Feb 24, 2026
d9c8a49
Update docs and tests
kevinjwang1 Feb 24, 2026
033d493
Merge branch 'main' into testRetries
kevinjwang1 Feb 24, 2026
9580ab0
Merge branch 'main' into testRetries
kevinjwang1 Feb 25, 2026
8f78f70
Make maxAttempts visible in UI dialog box
kevinjwang1 Feb 25, 2026
b7eaed9
fix snapshot
kevinjwang1 Feb 25, 2026
29637f1
Merge branch 'main' into testRetries
kevinjwang1 Feb 25, 2026
c9d6d29
Merge branch 'main' into testRetries
kevinjwang1 Feb 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/cli/src/config/config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -859,6 +859,7 @@ export async function loadCliConfig(
fakeResponses: argv.fakeResponses,
recordResponses: argv.recordResponses,
retryFetchErrors: settings.general?.retryFetchErrors,
maxAttempts: settings.general?.maxAttempts,
ptyInfo: ptyInfo?.name,
disableLLMCorrection: settings.tools?.disableLLMCorrection,
rawOutput: argv.rawOutput,
Expand Down
Loading