-
Notifications
You must be signed in to change notification settings - Fork 13k
feat (core): Implement tracker related SI changes #19964
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 25 commits
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
b5db5d3
feat(core): implement task tracker foundation and service (Phase 1)
anj-s f737126
feat(core,cli): implement task tracker tools and feature flag (Phase 2)
anj-s 448af0a
chore(core): improve ID generation and add runtime task validation
anj-s 2d6ee8f
fix: address code review comments from bot in trackerService.ts
anj-s 9618f8f
Merge branch 'u/anj/task-tracker-phase-1' into u/anj/task-tracker-pha…
anj-s 6a24077
docs: update implementation plan for Phase 2
anj-s ae96477
feat(tracker): move tracker storage to project temp directory
anj-s 91e7881
Merge branch 'u/anj/task-tracker-phase-1' into u/anj/task-tracker-pha…
anj-s e6b68e7
feat(tracker): integrate dynamic storage path in Config and tools
anj-s ba73124
feat(tracker): simplify tracker storage path
anj-s e32d8a2
Merge branch 'u/anj/task-tracker-phase-1' into u/anj/task-tracker-pha…
anj-s 1e743ea
feat(tracker): update config to use simplified tracker path
anj-s 23194dd
feat(tracker): restore session-specific nested storage path
anj-s de0ce2c
Merge branch 'u/anj/task-tracker-phase-1' into u/anj/task-tracker-pha…
anj-s eed1ca6
feat(tracker): restore nested tracker path in Config
anj-s eb33db5
feat(tracker): simplify tracker storage path and flatten directory st…
anj-s daf9da2
fix(tracker): lazily initialize tracker directory
anj-s 41cf395
chore(tracker): remove plans configuration directory from git tracking
anj-s fc298e3
remove .gitignore changes
anj-s 30fe8ff
remove .gitignore changes
anj-s 5d31761
si changes: task tracker prep implementation
anj-s 53755c5
si changes
anj-s ed8a773
wip temp settings change
anj-s aa1803f
feat(core): trigger task tracker based on complexity rather than form…
anj-s f76d73e
lint fix
anj-s 34788a7
prompt changes
anj-s 3d89cc5
remove old tool name
anj-s f5b6028
wip
anj-s c1252b4
Merge branch 'main' into u/anj/task-tracker-phase-3
anj-s 776c8aa
wip
anj-s 273deb6
Merge branch 'main' into u/anj/task-tracker-phase-3
anj-s ed7ecde
revert svg files that should not be modified
anj-s File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -154,19 +154,19 @@ export const LS_TOOL_NAME_LEGACY = 'list_directory'; // Just to be safe if anyth | |
|
|
||
| export const EDIT_TOOL_NAMES = new Set([EDIT_TOOL_NAME, WRITE_FILE_TOOL_NAME]); | ||
|
|
||
| export const TRACKER_CREATE_TASK_TOOL_NAME = 'tracker_create_task'; | ||
| export const TRACKER_UPDATE_TASK_TOOL_NAME = 'tracker_update_task'; | ||
| export const TRACKER_GET_TASK_TOOL_NAME = 'tracker_get_task'; | ||
| export const TRACKER_LIST_TASKS_TOOL_NAME = 'tracker_list_tasks'; | ||
| export const TRACKER_ADD_DEPENDENCY_TOOL_NAME = 'tracker_add_dependency'; | ||
| export const TRACKER_VISUALIZE_TOOL_NAME = 'tracker_visualize'; | ||
|
|
||
| // Tool Display Names | ||
| export const WRITE_FILE_DISPLAY_NAME = 'WriteFile'; | ||
| export const EDIT_DISPLAY_NAME = 'Edit'; | ||
| export const ASK_USER_DISPLAY_NAME = 'Ask User'; | ||
| export const READ_FILE_DISPLAY_NAME = 'ReadFile'; | ||
| export const GLOB_DISPLAY_NAME = 'FindFiles'; | ||
| export const TRACKER_INIT_TOOL_NAME = 'tracker_init'; | ||
| export const TRACKER_CREATE_TASK_TOOL_NAME = 'tracker_create_task'; | ||
anj-s marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| export const TRACKER_UPDATE_TASK_TOOL_NAME = 'tracker_update_task'; | ||
| export const TRACKER_GET_TASK_TOOL_NAME = 'tracker_get_task'; | ||
| export const TRACKER_LIST_TASKS_TOOL_NAME = 'tracker_list_tasks'; | ||
| export const TRACKER_ADD_DEPENDENCY_TOOL_NAME = 'tracker_add_dependency'; | ||
| export const TRACKER_VISUALIZE_TOOL_NAME = 'tracker_visualize'; | ||
|
|
||
| /** | ||
| * Mapping of legacy tool names to their current names. | ||
|
|
@@ -229,6 +229,13 @@ export const ALL_BUILTIN_TOOL_NAMES = [ | |
| GET_INTERNAL_DOCS_TOOL_NAME, | ||
| ENTER_PLAN_MODE_TOOL_NAME, | ||
| EXIT_PLAN_MODE_TOOL_NAME, | ||
| TRACKER_INIT_TOOL_NAME, | ||
| TRACKER_CREATE_TASK_TOOL_NAME, | ||
| TRACKER_UPDATE_TASK_TOOL_NAME, | ||
| TRACKER_GET_TASK_TOOL_NAME, | ||
| TRACKER_LIST_TASKS_TOOL_NAME, | ||
| TRACKER_ADD_DEPENDENCY_TOOL_NAME, | ||
| TRACKER_VISUALIZE_TOOL_NAME, | ||
|
Comment on lines
+231
to
+236
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
| ] as const; | ||
|
|
||
| /** | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we're not updating legacy prompts: https://github.com/google-gemini/gemini-cli/blob/a5fd5d0b9fcafcc2eb1cc92e8e6405716dbb103f/GEMINI.md#development-conventions
Legacy Snippets: packages/core/src/prompts/snippets.legacy.ts is a snapshot of an older system prompt. Avoid changing the prompting verbiage to preserve its historical behavior; however, structural changes to ensure compilation or simplify the code are permitted.