fix: expand paste placeholders in TextInput on submit

[Jefftree]

Summary

Fixes large pastes in TextInput (used by action-required dialogs like "suggest changes") being submitted as literal placeholder strings (e.g. [Pasted Text: 9 lines]) instead of the actual pasted content.

Details

When a paste exceeds 5 lines or 500 chars, gemini-cli stores the real content in buffer.pastedContent and shows a compact placeholder in the input. InputPrompt already expanded these placeholders before submit, but TextInput was calling onSubmit(text) directly, sending the raw placeholder string to the model.

The fix expands placeholders in TextInput.handleKeyPress before calling onSubmit, using the keys from buffer.pastedContent directly — no new imports or shared utilities needed.

Related Issues

Closes #19944
Closes #19238

How to Validate

1. npm run build && npm start
2. Ask gemini to edit a file, wait for the action-required approval prompt
3. Choose "suggest changes"
4. Paste 5+ lines into the input and submit
5. Gemini should receive and respond to the actual pasted content, not [Pasted Text: N lines]

Pre-Merge Checklist

• Updated relevant documentation and README (if needed)
• Added/updated tests (if needed)
• Noted breaking changes (if any)
• Validated on required platforms/methods:
  • MacOS
    • npm run

[gemini-code-assist]

Summary of Changes

Hello @Jefftree, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical bug in the TextInput component where large pasted content was not correctly processed upon submission. The change ensures that any placeholder text representing a larger paste is expanded to its original content before being passed to the onSubmit handler, thereby maintaining data integrity and improving user experience in interactive prompts.

Highlights

• Paste Placeholder Expansion: Implemented logic within the TextInput component to expand paste placeholders (e.g., '[Pasted Text: 9 lines]') into their actual content before submission, preventing literal placeholder strings from being sent.
• Bug Fix: Resolved an issue where large pastes in TextInput were submitted as placeholder strings instead of the intended content, particularly affecting action-required dialogs like 'suggest changes'.
• Test Coverage: Added new unit tests to TextInput.test.tsx to ensure that paste placeholders are correctly expanded on submit and that normal text submission remains unaffected.

Changelog

• packages/cli/src/ui/components/shared/TextInput.test.tsx
  • Added a test case to verify that paste placeholders are expanded to their real content on submit.
  • Added a test case to confirm that text is submitted unchanged when no pasted content is present.
• packages/cli/src/ui/components/shared/TextInput.tsx
  • Modified the handleKeyPress function to process and expand paste placeholders before calling the onSubmit callback.
  • Updated the dependency array for the useKeypress hook to include buffer.pastedContent.

Activity

• The author has added new tests to validate the fix.
• The author has validated the changes on MacOS using npm run.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

The pull request correctly addresses the issue where large pastes in TextInput were being submitted as literal placeholder strings. However, the expansion logic in TextInput.tsx has a potential bug when multiple pastes are present due to placeholder string overlapping. I've suggested a regex-based approach that is more robust and efficient, following patterns already established in the codebase.

[jackwotherspoon]

I think a small shared helper for the paste expansion will help reduce the tests and make sure things don't drift in the future.

[jackwotherspoon]

Feedback on plan worked great and expanded! 👍

I think we may be missing one spot though. The ask user tool is not expanding the pastes... @Jefftree can you see if there is one more call site that needs to use the new helper function?

The file in question is AskUserDialog.tsx to update.

[Jefftree]

Feedback on plan worked great and expanded! 👍

I think we may be missing one spot though. The ask user tool is not expanding the pastes... @Jefftree can you see if there is one more call site that needs to use the new helper function?

The file in question is AskUserDialog.tsx to update.

Found the code path. Same target as #19286, fixed!

[SandyTao520]

need to expand here as well

[SandyTao520]

and expand here

[SandyTao520]

Overall LGTM, please fix the tests and the 2 remaining spots we're not expanding the placeholder.

[Jefftree]

Fixed.

Overall LGTM, please fix the tests and the 2 remaining spots we're not expanding the placeholder.

[jackwotherspoon]

Looks like there may be a related test failure to take a look at @Jefftree

[Jefftree]

Looks like there may be a related test failure to take a look at @Jefftree

Done.

done