Add support for numpad keys

[ved015]

Summary

Add escape sequences for numpad keys in KEY_INFO_MAP to prevent numpad key from being ignored

Related Issues

Closes #12288 #19469

Pre-Merge Checklist

• Updated relevant documentation and README (if needed)
• Added/updated tests (if needed)
• Noted breaking changes (if any)
• Validated on required platforms/methods:
  • MacOS
    • npm run
    • npx
    • Docker
    • Podman
    • Seatbelt
  • Windows
    • npm run
    • npx
    • Docker
  • Linux
    • npm run
    • npx
    • Docker

@scidomino please have a look

[gemini-code-assist]

Summary of Changes

Hello @ved015, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the CLI's keypress handling by introducing comprehensive support for numpad keys. It addresses previous limitations where numpad inputs were ignored, thereby improving the user experience for applications requiring numerical input and ensuring these keys are correctly processed.

Highlights

• Numpad Key Support: Extended the KEY_INFO_MAP type definition to include an optional sequence property, allowing numpad keys to be recognized and processed correctly.
• New Numpad Mappings: Added specific escape sequences for numpad keys (0-9, +, -, *, /, .) to the KEY_INFO_MAP to ensure their proper identification.
• Keypress Processing Logic: Updated the emitKeys function to utilize the new sequence property from KEY_INFO_MAP, ensuring numpad key presses are correctly inserted into the input stream.

Changelog

• packages/cli/src/ui/contexts/KeypressContext.tsx
  • Updated the KEY_INFO_MAP interface to support an optional sequence property for key definitions.
  • Added new entries to KEY_INFO_MAP for various numpad keys, including numbers, arithmetic operators, and the decimal point.
  • Modified the emitKeys function to correctly process and insert key sequences defined in KEY_INFO_MAP, specifically enabling numpad input.

Activity

• The author, ved015, created the pull request to add numpad key support.
• The author has marked the 'Noted breaking changes (if any)' checklist item as complete.
• The author requested a review from @scidomino.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request adds support for numpad keys by defining their escape sequences in KEY_INFO_MAP. The implementation correctly introduces a sequence property to handle the character output of these keys. However, the chosen name for the numpad keys is ambiguous as it's identical to the names for the number row keys. This prevents distinguishing between them, for example in key bindings, which violates the guidelines for using descriptive and unique identifiers. I've suggested using more specific names like numpad0, numpad1, etc., to resolve this ambiguity while preserving the intended character insertion behavior.

[scidomino]

I didn't see you had a PR for this. Closing this in favor of the one I wrote:

#19659

[ved015]

I didn't see you had a PR for this. Closing this in favor of the one I wrote:

#19659

Ok no issue