feat(cli): update approval mode cycle order by jerop · Pull Request #19254 · google-gemini/gemini-cli

jerop · 2026-02-17T15:00:20Z

Changes the cycle order of approval modes via shift+tab from Default --> Plan --> Auto-Edit to Default --> Auto-Edit --> Plan.
Updates the UI hints to reflect the new order and refactors the hint strings into constants.
Updates docs/cli/plan-mode.md to reflect the new approval mode cycling order.

Fixes #19020

Changes the cycle order of approval modes via `shift+tab` from `Default --> Plan --> Auto-Edit` to `Default --> Auto-Edit --> Plan`. Also updates the UI hints to reflect the new order and refactors the hint strings into constants. Updates `docs/cli/plan-mode.md` to reflect the new approval mode cycling order. Fixes #19020

gemini-code-assist · 2026-02-17T15:00:41Z

Summary of Changes

Hello @jerop, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request reconfigures the cycling sequence for approval modes within the CLI, making the Auto-Edit mode more accessible after Default. It also centralizes and updates the associated user interface hints to accurately reflect this new flow, ensuring a consistent user experience and improved code maintainability. The changes are reflected across the core logic, UI components, and documentation.

Highlights

Approval Mode Cycle Order: The Shift+Tab keyboard shortcut now cycles through approval modes in the order: Default -> Auto-Edit -> Plan. Previously, the order was Default -> Plan -> Auto-Edit.
UI Hint Refactoring: All UI hint strings for the ApprovalModeIndicator component have been refactored into a centralized APPROVAL_MODE_TEXT constant object, improving maintainability and consistency.
Documentation Update: The docs/cli/plan-mode.md file has been updated to reflect the new approval mode cycling order.
Test Updates: Existing unit tests for ApprovalModeIndicator were converted to snapshot tests, and tests for useApprovalModeIndicator were updated to reflect the new cycle order logic.

Changelog

docs/cli/plan-mode.md
- Updated the keyboard shortcut description to reflect the new approval mode cycle order.
packages/cli/src/ui/components/ApprovalModeIndicator.test.tsx
- Migrated explicit toContain assertions to snapshot testing for various approval mode states.
packages/cli/src/ui/components/ApprovalModeIndicator.tsx
- Introduced APPROVAL_MODE_TEXT constant for all UI hint strings.
- Updated the component to use the new APPROVAL_MODE_TEXT constants for displaying approval mode and sub-text hints.
packages/cli/src/ui/components/snapshots/ApprovalModeIndicator.test.tsx.snap
- Added a new snapshot file to capture the rendered output of the ApprovalModeIndicator component.
packages/cli/src/ui/hooks/useApprovalModeIndicator.test.ts
- Updated test descriptions and assertions to align with the revised approval mode cycling logic.
packages/cli/src/ui/hooks/useApprovalModeIndicator.ts
- Modified the switch statement logic to change the order of approval modes when cycling via Shift+Tab.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request changes the approval mode cycle order and updates the UI hints. No security vulnerabilities were found. The refactoring of UI strings into constants improves maintainability, and the new snapshot-based tests enhance UI consistency. The changes are consistently applied across the application logic, UI components, tests, and documentation, making this a well-executed and clean pull request.

github-actions · 2026-02-17T15:03:48Z

Size Change: +457 B (0%)

Total Size: 24.4 MB

ℹ️ View Unchanged

Filename	Size	Change
`./bundle/gemini.js`	24.4 MB	+457 B (0%)
`./bundle/sandbox-macos-permissive-open.sb`	890 B	0 B
`./bundle/sandbox-macos-permissive-proxied.sb`	1.31 kB	0 B
`./bundle/sandbox-macos-restrictive-open.sb`	3.36 kB	0 B
`./bundle/sandbox-macos-restrictive-proxied.sb`	3.56 kB	0 B
`./bundle/sandbox-macos-strict-open.sb`	4.82 kB	0 B
`./bundle/sandbox-macos-strict-proxied.sb`	5.02 kB	0 B

_{compressed-size-action}

skeshive · 2026-02-17T17:07:25Z

/patch preview

github-actions · 2026-02-17T17:10:32Z

🚀 Patch PR Created!

📋 Patch Details:

Environment: prod
Channel: preview → will publish to npm tag preview
Commit: e5ff2023ad0159ee88b4f5ad803168e495fe81bb
Hotfix Branch: hotfix/v0.29.0-preview.3/0.29.0-preview.4/preview/cherry-pick-e5ff202/pr-19254
Hotfix PR: #19264

📝 Next Steps:

Review and approve the hotfix PR: #19264
Once merged, the patch release will automatically trigger
You'll receive updates here when the release completes

🔗 Track Progress:

View hotfix PR #19264

github-actions · 2026-02-17T18:25:30Z

🚀 Patch Release Started!

📋 Release Details:

Environment: prod
Channel: preview → publishing to npm tag preview
Version: v0.29.0-preview.3
Hotfix PR: Merged ✅
Release Branch: release/v0.29.0-preview.3-pr-19254

⏳ Status: The patch release is now running. You'll receive another update when it completes.

🔗 Track Progress:

View release workflow

github-actions · 2026-02-17T18:55:07Z

✅ Patch Release Complete!

📦 Release Details:

Version: 0.29.0-preview.4
NPM Tag: preview
Channel: preview
Dry Run: false

🎉 Status: Your patch has been successfully released and published to npm!

📝 What's Available:

GitHub Release: View release v0.29.0-preview.4
NPM Package: npm install @google/gemini-cli@preview

🔗 Links:

jerop requested review from a team as code owners February 17, 2026 15:00

gemini-code-assist bot reviewed Feb 17, 2026

View reviewed changes

jerop changed the title ~~feat(cli): update approval mode cycle order and UI hints~~ feat(cli): update approval mode cycle order Feb 17, 2026

jerop enabled auto-merge February 17, 2026 15:03

Adib234 approved these changes Feb 17, 2026

View reviewed changes

jerop added this pull request to the merge queue Feb 17, 2026

Merged via the queue into main with commit e5ff202 Feb 17, 2026
30 of 31 checks passed

jerop deleted the fix/approval-mode-cycle-order branch February 17, 2026 15:27

github-actions bot pushed a commit that referenced this pull request Feb 17, 2026

feat(cli): update approval mode cycle order (#19254)

545406d

gemini-code-assist bot mentioned this pull request Feb 18, 2026

Changelog for v0.30.0-preview.0 #19364

Merged

kuishou68 pushed a commit to iOfficeAI/aioncli that referenced this pull request Feb 27, 2026

feat(cli): update approval mode cycle order (google-gemini#19254)

e6e5b1d

tripleyoung pushed a commit to tripleyoung/gemini-cli that referenced this pull request Feb 27, 2026

feat(cli): update approval mode cycle order (google-gemini#19254)

73997fc

tripleyoung pushed a commit to tripleyoung/gemini-cli that referenced this pull request Feb 27, 2026

feat(cli): update approval mode cycle order (google-gemini#19254)

e35d1d8

liamhelmer pushed a commit to badal-io/gemini-cli that referenced this pull request Mar 12, 2026

feat(cli): update approval mode cycle order (google-gemini#19254)

b254fff

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(cli): update approval mode cycle order#19254

feat(cli): update approval mode cycle order#19254
jerop merged 1 commit intomainfrom
fix/approval-mode-cycle-order

jerop commented Feb 17, 2026 •

edited

Loading

Uh oh!

gemini-code-assist bot commented Feb 17, 2026

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

github-actions bot commented Feb 17, 2026

Uh oh!

Uh oh!

skeshive commented Feb 17, 2026

Uh oh!

github-actions bot commented Feb 17, 2026

Uh oh!

github-actions bot commented Feb 17, 2026

Uh oh!

github-actions bot commented Feb 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

jerop commented Feb 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gemini-code-assist bot commented Feb 17, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

github-actions bot commented Feb 17, 2026

Uh oh!

Uh oh!

skeshive commented Feb 17, 2026

Uh oh!

github-actions bot commented Feb 17, 2026

Uh oh!

github-actions bot commented Feb 17, 2026

Uh oh!

github-actions bot commented Feb 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

jerop commented Feb 17, 2026 •

edited

Loading