-
Notifications
You must be signed in to change notification settings - Fork 13k
feat: redesign header to be compact with ASCII icon #18713
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
f307ff0
feat(ui): redesign header to be compact with ASCII icon
keithguerin 39754c5
fix(ui): reuse UserIdentity component in AppHeader per TL feedback
keithguerin c656168
feat(ui): redesign header to be compact with ASCII icon
keithguerin 22f20d8
fix(ui): move sync file I/O out of render loop in AppHeader
keithguerin a4857ca
test(ui): fix Tips test and update all snapshots for compact header
keithguerin f75d6e4
test(ui): update AppHeader snapshots after reusing UserIdentity
keithguerin b32ca37
test(ui): update snapshots and fix test utility crashes for compact h…
keithguerin 84d5f30
test(ui): update snapshots after rebase and clean build
keithguerin e7a2b18
chore: update copyright year
keithguerin f576e5b
test(ui): update snapshots and address reviewer feedback
keithguerin 16e1e0b
Merge branch 'main' into feat/redesign-header-compact
jacob314 6da8abc
Revert unintended changes to render.tsx and startup-header.png
jacob314 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
configprop has been removed from theTipscomponent, but it is still being passed here. This should be removed to fix the compilation error.