-
Notifications
You must be signed in to change notification settings - Fork 13k
ui: update & subdue footer colors and animate progress indicator #18570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
2df1f31
ui: update & subdue footer colors and animate progress indicator
keithguerin 1620128
ui: increase user background contrast to 16%
keithguerin 16bc4c5
ui: refine user background contrast, borders, and thinking behavior
keithguerin 4a09633
test: update snapshots and unit tests for UI refinements
keithguerin 2d86f77
ui: fix logic regression for 'esc to cancel' hint
keithguerin 0ef4fa7
Merge branch 'main' and restore Composer.tsx to match main's layout
keithguerin 34220c8
Merge branch 'main' into ui-subdue-colors, favoring remote changes
keithguerin a880d41
chore: update test snapshots after merge
keithguerin 1c33af7
ui: change thinking text color to white and make it italic
keithguerin b135441
fix(evals): make hierarchical memory theme test more robust
keithguerin 2d13d98
Merge remote-tracking branch 'origin/main' into ui-subdue-colors
keithguerin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The refactoring of the condition for
showEscToCancelHintseems to have introduced a logic change that might be a regression. Previously, the visibility of the hint was tied toshowLoadingIndicator, which included the condition(!uiState.embeddedShellFocused || uiState.isBackgroundShellVisible). The new logic uses!uiState.embeddedShellFocused, which is more restrictive. This means the 'esc to cancel' hint will no longer appear when an embedded shell is focused, even if a background shell is visible, which might not be the intended behavior. To restore the original logic, the condition should also check foruiState.isBackgroundShellVisible.References
Esc-Escshortcut should clear the input buffer, including when it contains only whitespace. UI hints for this action should be consistent with this behavior.