Skip to content

Add autoconfigure memory usage setting to the dialog #18510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jacob314 merged 4 commits into from
Feb 10, 2026
Merged

Add autoconfigure memory usage setting to the dialog #18510

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
314f400
Add autoconfigure memory usage setting to the dialog
jacob314 Feb 3, 2026
95bbda7
Merge branch 'main' into autoconfig_memory
jacob314 Feb 7, 2026
d47dd7c
Apply suggestions from code review
jacob314 Feb 7, 2026
9e540e7
Merge branch 'main' into autoconfig_memory
jacob314 Feb 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions docs/cli/settings.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,12 @@ they appear in the UI.
| Folder Trust | `security.folderTrust.enabled` | Setting to track whether Folder trust is enabled. | `true` |
| Enable Environment Variable Redaction | `security.environmentVariableRedaction.enabled` | Enable redaction of environment variables that may contain secrets. | `false` |

### Advanced

| UI Label | Setting | Description | Default |
| --------------------------------- | ------------------------------ | --------------------------------------------- | ------- |
| Auto Configure Max Old Space Size | `advanced.autoConfigureMemory` | Automatically configure Node.js memory limits | `false` |

### Experimental

| UI Label | Setting | Description | Default |
Expand Down
2 changes: 1 addition & 1 deletion packages/cli/src/config/settingsSchema.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,7 @@ describe('SettingsSchema', () => {
expect(
getSettingsSchema().advanced.properties.autoConfigureMemory
.showInDialog,
).toBe(false);
).toBe(true);
});

it('should infer Settings type correctly', () => {
Expand Down
2 changes: 1 addition & 1 deletion packages/cli/src/config/settingsSchema.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1413,7 +1413,7 @@ const SETTINGS_SCHEMA = {
requiresRestart: true,
default: false,
description: 'Automatically configure Node.js memory limits',
showInDialog: false,
showInDialog: true,
},
dnsResolutionOrder: {
type: 'string',
Expand Down
21 changes: 18 additions & 3 deletions packages/cli/src/utils/settingsUtils.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,17 @@ describe('SettingsUtils', () => {
default: {},
description: 'Advanced settings for power users.',
showInDialog: false,
properties: {
autoConfigureMemory: {
type: 'boolean',
label: 'Auto Configure Max Old Space Size',
category: 'Advanced',
requiresRestart: true,
default: false,
description: 'Automatically configure Node.js memory limits',
showInDialog: true,
},
},
},
ui: {
type: 'object',
Expand Down Expand Up @@ -395,11 +406,15 @@ describe('SettingsUtils', () => {
expect(uiKeys).not.toContain('ui.theme'); // This is now marked false
});

it('should not include Advanced category settings', () => {
it('should include Advanced category settings', () => {
const categories = getDialogSettingsByCategory();

// Advanced settings should be filtered out
expect(categories['Advanced']).toBeUndefined();
// Advanced settings should now be included because of autoConfigureMemory
expect(categories['Advanced']).toBeDefined();
const advancedSettings = categories['Advanced'];
expect(advancedSettings.map((s) => s.key)).toContain(
'advanced.autoConfigureMemory',
);
});

it('should include settings with showInDialog=true', () => {
Expand Down
Loading