feat: Add voice input with pluggable backend (Gemini zero-install + Whisper) #18499
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,84 @@ | ||
| /** | ||
| * @license | ||
| * Copyright 2026 Google LLC | ||
| * SPDX-License-Identifier: Apache-2.0 | ||
| */ | ||
|
|
||
| import { afterEach, describe, expect, it } from 'vitest'; | ||
| import { TestRig } from '@google/gemini-cli-test-utils'; | ||
| import path from 'node:path'; | ||
| import { fileURLToPath } from 'node:url'; | ||
| import stripAnsi from 'strip-ansi'; | ||
|
|
||
| const __dirname = path.dirname(fileURLToPath(import.meta.url)); | ||
|
|
||
| describe.skipIf(process.platform === 'win32')('Voice Whisper PTY repro', () => { | ||
| let rig: TestRig | undefined; | ||
|
|
||
| afterEach(async () => { | ||
| await rig?.cleanup(); | ||
| }); | ||
|
|
||
| it('repro: whisper can remain stuck in "Speak now..." after Esc in a real PTY session', async () => { | ||
| const fakeResponsesPath = path.join( | ||
| __dirname, | ||
| '../test-utils/fixtures/simple.responses', | ||
| ); | ||
|
|
||
| rig = new TestRig(); | ||
| rig.setup('voice-whisper-pty-repro', { | ||
| fakeResponsesPath, | ||
| }); | ||
|
|
||
| const ignoreSigintScript = rig.createScript( | ||
| 'ignore-sigint.js', | ||
| [ | ||
| "process.on('SIGINT', () => {});", | ||
| 'setInterval(() => {}, 1000);', | ||
| '', | ||
| ].join('\n'), | ||
| ); | ||
|
|
||
| rig.createScript( | ||
| 'sox', | ||
| [ | ||
| '#!/usr/bin/env bash', | ||
| `exec "${process.execPath}" "${ignoreSigintScript}" "$@"`, | ||
| '', | ||
| ].join('\n'), | ||
| ); | ||
|
|
||
| // Make the fake recorder executable. | ||
| const fs = await import('node:fs/promises'); | ||
| await fs.chmod(path.join(rig.testDir!, 'sox'), 0o755); | ||
|
|
||
| const run = await rig.runInteractive({ | ||
| env: { | ||
| PATH: `${rig.testDir}:${process.env['PATH'] ?? ''}`, | ||
| GEMINI_API_KEY: 'test-key', | ||
| }, | ||
| }); | ||
|
|
||
| const submitCommand = async (command: string) => { | ||
| await run.sendKeys(command); | ||
| await new Promise((resolve) => setTimeout(resolve, 75)); | ||
| await run.sendKeys('\r'); | ||
| }; | ||
|
|
||
| await submitCommand('/voice provider whisper'); | ||
| await run.expectText('Voice transcription backend set to: whisper', 10000); | ||
|
|
||
| await submitCommand('/voice enable'); | ||
| await run.expectText('Voice input enabled', 10000); | ||
|
|
||
| await run.sendText(' '); | ||
| await new Promise((resolve) => setTimeout(resolve, 120)); | ||
| await run.sendText(' '); | ||
| await run.expectText('Speak now...', 10000); | ||
|
|
||
| await run.sendText('\u001B'); | ||
| await new Promise((resolve) => setTimeout(resolve, 500)); | ||
|
|
||
| expect(stripAnsi(run.output)).toContain('Speak now...'); | ||
| }, 60000); | ||
| }); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets add an additional setting that indicates whether voice support is enabled or not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done —
voice.enabledis implemented insettingsSchema.tsand read inAppContainer.tsx. Whenfalse, the backend is not initialized and keyboard shortcuts are suppressed entirely (the key handler now checksisEnabledbefore consuming the keypress).