refactor(cli): standardize on 'reload' verb for refreshing components#18347
refactor(cli): standardize on 'reload' verb for refreshing components#18347MushuEE wants to merge 1 commit intogoogle-gemini:mainfrom
Conversation
Summary of ChangesHello @MushuEE, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly improves the consistency and user experience of the CLI by standardizing the verb used for re-initializing various components. By consolidating 'refresh', 'restart', and 'reload' into a single 'reload' verb, the CLI's command structure becomes more predictable and easier to navigate. This change is implemented while ensuring that existing scripts and user habits are not broken through the intelligent use of aliases, providing a smooth transition for all users. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request is a good refactoring that standardizes the verb for re-initializing components to reload across several CLI commands. The changes are consistent and correctly use aliases for backward compatibility. I've found a couple of minor inconsistencies where the refactoring could be made more complete: one in an internal function name and another in a user-facing message. Addressing these will ensure full consistency with the new standard.
bfff8d1 to
eec74fc
Compare
bfdfc4b to
e24193f
Compare
e24193f to
ae364ac
Compare
This commit standardizes the primary verb for re-initializing components (skills, agents, commands, memory, mcp, and extensions) to 'reload'. It maintains 'refresh' and 'restart' as aliases for backward compatibility. - Updates all UI feedback strings to 'Reloading...' - Updates Informative Tips in the UI - Synchronizes documentation and settings schemas - Ensures full symmetry across all extensibility types Co-authored-by: Krishna Korade <[email protected]> Closes #18347
This commit standardizes the primary verb for re-initializing components (skills, agents, commands, memory, mcp, and extensions) to 'reload'. It maintains 'refresh' and 'restart' as aliases for backward compatibility. - Updates all UI feedback strings to 'Reloading...' - Updates Informative Tips in the UI - Synchronizes documentation and settings schemas - Ensures full symmetry across all extensibility types Co-authored-by: Krishna Korade <[email protected]> Closes #18347
This commit standardizes the primary verb for re-initializing components (skills, agents, commands, memory, mcp, and extensions) to 'reload'. It maintains 'refresh' and 'restart' as aliases for backward compatibility. - Updates all UI feedback strings to 'Reloading...' - Updates Informative Tips in the UI - Synchronizes documentation and settings schemas - Ensures full symmetry across all extensibility types Co-authored-by: Krishna Korade <[email protected]> Closes #18347
This commit standardizes the primary verb for re-initializing components (skills, agents, commands, memory, mcp, and extensions) to 'reload'. It maintains 'refresh' and 'restart' as aliases for backward compatibility. - Updates all UI feedback strings to 'Reloading...' - Updates Informative Tips in the UI - Synchronizes documentation and settings schemas - Ensures full symmetry across all extensibility types Co-authored-by: Krishna Korade <[email protected]> Closes #18347
This commit standardizes the primary verb for re-initializing components (skills, agents, commands, memory, mcp, and extensions) to 'reload'. It maintains 'refresh' and 'restart' as aliases for backward compatibility. - Updates all UI feedback strings to 'Reloading...' - Updates Informative Tips in the UI - Synchronizes documentation and settings schemas - Ensures full symmetry across all extensibility types Co-authored-by: Krishna Korade <[email protected]> Closes #18347
Summary
This PR standardizes the primary verb for re-initializing components across the CLI to
reload. Previously, the CLI used a mix ofrefresh,restart, andreloadacross various namespaces, leading to inconsistent help menus and autocomplete behavior.Details
The following subcommands have been updated to use
reloadas their primary name, while preserving the original verbs asaltNamesto ensure full backwards compatibility for existing users and scripts:/mcp refresh->/mcp reload(alias:refresh)/agents refresh->/agents reload(alias:refresh)/extensions restart->/extensions reload(alias:restart)/memory refresh->/memory reload(alias:refresh)Additionally, subcommand descriptions, usage strings, and interactive feedback messages (e.g., "Reloading...") have been updated to match this new standard.
Related Issues
Closes #18345
How to Validate
/mcp reload,/agents reload,/extensions reload, and/memory reload. Each should function correctly and display "Reloading..." or "Reloaded..." messages./mcp refresh,/agents refresh,/extensions restart, and/memory refresh. These should still work silently and execute the same logic./mcp [TAB]or/extensions --helpand confirm thatreloadis the suggested/displayed subcommand.npm test -w @google/gemini-cli -- src/ui/commands/should pass all 320 tests.Pre-Merge Checklist