Skip to content

feat(core): enable getUserTierName in config#18265

Merged
sehoon38 merged 1 commit intomainfrom
sehoon/user_identity
Feb 4, 2026
Merged

feat(core): enable getUserTierName in config#18265
sehoon38 merged 1 commit intomainfrom
sehoon/user_identity

Conversation

@sehoon38
Copy link
Copy Markdown
Contributor

@sehoon38 sehoon38 commented Feb 4, 2026

Summary

This PR enables the getUserTierName configuration method and updates the corresponding test case, resolving a pending TODO.

Details

  • Updated packages/core/src/config/config.test.ts to assert that getUserTierName returns the correct tier name instead of undefined.

Related Issues

Fixes https://github.com/google-gemini/maintainers-gemini-cli/issues/1275

How to Validate

Run the configuration tests:

npm test -w @google/gemini-cli-core -- src/config/config.test.ts

Pre-Merge Checklist

  • Updated relevant documentation and README (if needed)
  • Added/updated tests (if needed)
  • Noted breaking changes (if any)
  • Validated on required platforms/methods:
    • MacOS
      • npm run

@sehoon38 sehoon38 requested a review from a team as a code owner February 4, 2026 03:11
@gemini-cli
Copy link
Copy Markdown
Contributor

gemini-cli bot commented Feb 4, 2026

Hi @sehoon38, thank you so much for your contribution to Gemini CLI! We really appreciate the time and effort you've put into this.

We're making some updates to our contribution process to improve how we track and review changes. Please take a moment to review our recent discussion post: Improving Our Contribution Process & Introducing New Guidelines.

Key Update: Starting January 26, 2026, the Gemini CLI project will require all pull requests to be associated with an existing issue. Any pull requests not linked to an issue by that date will be automatically closed.

Thank you for your understanding and for being a part of our community!

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @sehoon38, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request re-enables the getUserTierName configuration method, which was previously disabled. This change ensures that the system can correctly retrieve and report the user's tier name, improving the accuracy of configuration-related information and resolving a long-standing TODO.

Highlights

  • getUserTierName method enabled: The getUserTierName configuration method has been re-enabled, allowing it to return the actual user tier name instead of undefined.
  • Test case updated: The corresponding test case in config.test.ts has been updated to assert that getUserTierName now returns the correct tier name, resolving a pending TODO.
Changelog
  • packages/core/src/config/config.test.ts
    • Updated the getUserTierName test expectation from toBeUndefined() to toBe(mockTierName).
    • Removed the TODO(#1275) comment, indicating the resolution of the issue.
  • packages/core/src/config/config.ts
    • Modified the getUserTierName method to return this.contentGenerator?.userTierName instead of a hardcoded undefined.
    • Removed the TODO(#1275) comment related to re-enabling the user tier display.
Activity
  • The author, sehoon38, initiated this pull request to address and resolve a long-standing TODO item related to the getUserTierName functionality.
  • The PR includes updated test cases to validate the re-enabled feature.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request enables the getUserTierName method in the Config class, resolving a TODO. The implementation correctly retrieves the tier name from the contentGenerator, and the corresponding test case has been updated to verify the new functionality. The changes are straightforward and well-implemented. I have no further comments.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 4, 2026

Size Change: +27 B (0%)

Total Size: 23.7 MB

ℹ️ View Unchanged
Filename Size Change
./bundle/gemini.js 23.7 MB +27 B (0%)
./bundle/sandbox-macos-permissive-closed.sb 1.03 kB 0 B
./bundle/sandbox-macos-permissive-open.sb 890 B 0 B
./bundle/sandbox-macos-permissive-proxied.sb 1.31 kB 0 B
./bundle/sandbox-macos-restrictive-closed.sb 3.29 kB 0 B
./bundle/sandbox-macos-restrictive-open.sb 3.36 kB 0 B
./bundle/sandbox-macos-restrictive-proxied.sb 3.56 kB 0 B

compressed-size-action

@gemini-cli gemini-cli bot added the status/need-issue Pull requests that need to have an associated issue. label Feb 4, 2026
@sehoon38 sehoon38 added this pull request to the merge queue Feb 4, 2026
Merged via the queue into main with commit 94f4e5c Feb 4, 2026
31 checks passed
@sehoon38 sehoon38 deleted the sehoon/user_identity branch February 4, 2026 03:39
theerud pushed a commit to theerud/gemini-cli that referenced this pull request Feb 4, 2026
yuvrajangadsingh pushed a commit to yuvrajangadsingh/gemini-cli that referenced this pull request Feb 4, 2026
sidwan02 pushed a commit to sidwan02/gemini-cli-gemma that referenced this pull request Feb 6, 2026
kuishou68 pushed a commit to iOfficeAI/aioncli that referenced this pull request Feb 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status/need-issue Pull requests that need to have an associated issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants