-
Notifications
You must be signed in to change notification settings - Fork 13k
Adding a new parameter for model, and updating the default to 2.5 Flash. #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,50 @@ | ||
| import { CliArgs } from './args.js'; // Assuming CliArgs contains the needed fields | ||
|
|
||
| interface GlobalConfig { | ||
| model: string; | ||
| // Add other global config values here if needed | ||
| // e.g., targetDir?: string; | ||
| } | ||
|
|
||
| let config: GlobalConfig | null = null; | ||
|
|
||
| /** | ||
| * Initializes the global configuration. Should only be called once at application startup. | ||
| * @param args The parsed command-line arguments. | ||
| */ | ||
| export function initializeConfig(args: Pick<CliArgs, 'model'>): void { | ||
| if (config) { | ||
| console.warn('Global configuration already initialized.'); | ||
| return; | ||
| } | ||
| if (!args.model) { | ||
| // This shouldn't happen if default is set correctly in args.ts | ||
| throw new Error('Model not provided during config initialization.'); | ||
| } | ||
| config = { | ||
| model: args.model, | ||
| // Initialize other config values from args here | ||
| }; | ||
| } | ||
|
|
||
| /** | ||
| * Retrieves the globally stored configuration. | ||
| * Throws an error if the configuration has not been initialized. | ||
| * @returns The global configuration object. | ||
| */ | ||
| export function getConfig(): GlobalConfig { | ||
| if (!config) { | ||
| throw new Error( | ||
| 'Global configuration accessed before initialization. Call initializeConfig() first.', | ||
| ); | ||
| } | ||
| return config; | ||
| } | ||
|
|
||
| /** | ||
| * Helper function to get the configured Gemini model name. | ||
| * @returns The model name string. | ||
| */ | ||
| export function getModel(): string { | ||
| return getConfig().model; | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should merge config into a single module.
Introduce a loadConfig that parses args, loads from environment, etc.
We should also avoid global state. Just pass a config type.