Improve compat across node versions #297
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Import Assertions were removed from Node v22 and replaced with Import Attributes. To be compatible with both, the simplest thing is to just use the filesystem APIs, even though they're more awkward.
Once everyone's on Node v22 or above, we can switch to using `import pkg from './package.json' with {type: 'json'};`
junyanxu
requested review from
hsubox76 and
junyanxu
and removed request for
junyanxu
junyanxu
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Import Assertions were removed from Node v22 and replaced with Import Attributes. To be compatible with both, the simplest thing is to just use the filesystem APIs, even though they're more awkward.
Once everyone's on Node v22 or above, we can switch to using
import pkg from './package.json' with {type: 'json'};