Add ability to set modelParams on getGenerativeModelFromCachedContent() #254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…etGenerativeModelFromCachedContent()
hsubox76
force-pushed
the
ch-add-model-params
branch
from
b99065d to
2974706
Compare
dlarocque
reviewed
Sep 11, 2024
Collaborator
dlarocque
left a comment
dlarocque
left a comment
There was a problem hiding this comment.
Is the failed node integration test a flake?
| apiKey: string; | ||
| getGenerativeModel(modelParams: ModelParams, requestOptions?: RequestOptions): GenerativeModel; | ||
| getGenerativeModelFromCachedContent(cachedContent: CachedContent, requestOptions?: RequestOptions): GenerativeModel; | ||
| getGenerativeModelFromCachedContent(cachedContent: CachedContent, modelParams?: Partial<ModelParams>, requestOptions?: RequestOptions): GenerativeModel; |
Collaborator
There was a problem hiding this comment.
Why do we make this Partial<>? Is ModelParams.model only optional when it's passed to this method?
Collaborator
Author
There was a problem hiding this comment.
None of the params are required here, and the whole object is optional, because cachedContent should have everything it needs to initialize (it always has "model").
dlarocque
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a modelParams arg to getGenerativeModelFromCachedContent(), allowing users to set generationConfig and safetySettings.