Skip to content

Fix String.endsWith returning false negatives #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix String.endsWith returning false negatives #155

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
678a145
Added edge case to test string ends with a suffix
dengjeffrey Jan 4, 2019
5a6c697
Fixed String.endsWith comparisons
dengjeffrey Jan 7, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/parser/string-methods.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,8 @@ module.exports = {
throw new Error(`${substr} is not a string.`);
}

return str.indexOf(substr) + substr.length === str.length;
const strSuffix = str.substring(str.length - substr.length, str.length)
return strSuffix === substr
},

replace(str, substr, replacement) {
Expand Down
2 changes: 2 additions & 0 deletions test/spec/lib/parser/string-methods.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,10 +36,12 @@ describe('stringMethods', function() {

it('returns true if the given string ends with the given substring', function() {
expect(stringMethods.endsWith('bar', 'ar')).to.be.true();
expect(stringMethods.endsWith('arbar', 'ar')).to.be.true();
});

it('returns false if the given string does not end with the given substring', function() {
expect(stringMethods.endsWith('bar', 'az')).to.be.false();
expect(stringMethods.endsWith('', 'az')).to.be.false();
});

});
Expand Down