debug: support alternate dlv batch files on Windows by stfulldev · Pull Request #4078 · golang/vscode-go

stfulldev · 2026-08-28T02:24:10Z

Windows cannot launch .bat or .cmd files directly with
child_process.spawn. As a result, a dlv path configured through
go.alternateTools failed before Delve could start.

Detect Windows batch tool paths, quote them, and enable shell execution
for DAP startup, remote-mode probing, and the legacy debug adapter.
Normal executables continue to run directly.

Add unit coverage for spawn command construction and a Windows
integration test that runs Delve through an alternate batch wrapper in
a path containing spaces.

The following checks pass locally:

npm run unit-test
npm run lint
npm run compile
VSCODE_GO_TEST_ALL=true go test ./...
go run tools/generate.go -w=false -gopls=true

The focused integration harness completes successfully on Linux. The
new regression test is Windows-only and will run in the Windows CI job.

Fixes #3986

google-cla · 2026-08-28T02:24:20Z

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

gopherbot · 2026-08-28T02:48:55Z

This PR (HEAD: e6e8df5) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/vscode-go/+/823444.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2026-08-28T03:23:51Z

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.