Repository navigation
Add support for locking table in pgx-driver - #992
Merged
Merged
Conversation
In order to support running migrations through PgBouncer which does not support advisory locks.
dhui
requested changes
Dec 20, 2023
Author
I don't have any plans to add it to the postgres driver, since we only use the pgx driver at the moment. |
Defer rollback of transactions
This was referenced Jan 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A common pattern in postgres deployment is to use pgbouncer in transaction pooling mode. This is to support at large number of concurrent clients to work around the process based postgres connection model.
Unfortunately pgbouncer does not support advisory locks in transaction pooling mode, which is the most commonly used mode. To work around this we introduce this traditional table lock method. As used in the cockroach driver. We expose the feature behind a config flag and default the config to advisory lock.