Skip to content

Implement WithConnection for sqlserver database driver - #794

Closed
selaux wants to merge 1 commit into
golang-migrate:masterfrom
selaux:implement-with-connection-for-sql-server
Closed

selaux wants to merge 1 commit into
golang-migrate:masterfrom
selaux:implement-with-connection-for-sql-server

Conversation

@selaux

@selaux selaux commented Aug 16, 2022 •

Copy link
Copy Markdown

Similar methods have already been implemented for the mysql and postgres database. This adds WithConnection(ctx context.Context, conn *sql.Conn, config *Config) (*SQLServer, error) to the SQL Server database driver as well.

Issues/PRs for this can be found here:

I tried to align as close as possible to the other implementations.

Note: The linter errors dont seem to be related to the contents of this PR.

@coveralls

coveralls commented Aug 16, 2022 •

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.03%) to 57.804% when pulling a5148ef on selaux:implement-with-connection-for-sql-server into 03613f1 on golang-migrate:master.

@selaux selaux closed this May 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants