Skip to content

use github.com/cockroachdb/cockroach-go/v2/crdb - #595

Merged
dhui merged 3 commits into
golang-migrate:masterfrom
DGollings:master
Jul 27, 2021
Merged

dhui merged 3 commits into
golang-migrate:masterfrom
DGollings:master

Conversation

@DGollings

Copy link
Copy Markdown
Contributor

In my case, for better go module support using a goproxy

Although github.com/cockroachdb/cockroach-go itself mentions to use /v2 and tests still pass. Seems to be a very minor change

@DGollings

Copy link
Copy Markdown
Contributor Author

noticed #424 and ran go mod tidy, seems that whatever was the issue then has been resolved?

@coveralls

coveralls commented Jul 14, 2021 •

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 503

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 57.369%

Totals Coverage Status
Change from base Build 502: 0.0%
Covered Lines: 3624
Relevant Lines: 6317

💛 - Coveralls

@dhui
dhui merged commit 586cc86 into golang-migrate:master Jul 27, 2021
@dhui

dhui commented Jul 27, 2021

Copy link
Copy Markdown
Member

Thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants