Repository navigation
fix(spanner): upgrade spanner client to latest to support NUMERIC types - #565
Conversation
dhui
left a comment
dhui
left a comment
There was a problem hiding this comment.
Thanks for reporting the issue and fixing it!
| expected: []string{"ALTER TABLE users ALTER COLUMN created SET OPTIONS (allow_commit_timestamp = true)"}, | ||
| }, | ||
| { | ||
| name: "column with NUMERIC type", |
There was a problem hiding this comment.
This only tests that cleanStatements() passes. It doesn't test running the statement against the emulator. Was this your intention?
There was a problem hiding this comment.
Whoops, just updated where the last spanner upgrade PR did #427 -- will add a migration to test this case as well. Let me know if there's anywhere else that should be updated!
There was a problem hiding this comment.
If DDL parsing is all you want to test, then this is fine. But if you want to test table creation, then this doesn't test that. I'm fine either way.
EDIT: I see you added a new example migration that creates a table w/ a numeric column. These examples should be run as part of a normal test
There was a problem hiding this comment.
Hi @dhui not sure I understand, when you say 'these examples' are you saying the tests are good as is, or that I should remove the migrations and add a new test function? If you have an example of what you're referring to that would be great
|
@dhui Looks like the Spanner tests pass -- Not sure why the Cassandra migrations would have failed. Possible they're flappy? |
3 participants
Update spanner library to latest,
cloud.google.com/go/spanner@v1.18.0This prevents
error: :1.57: got "NUMERIC", want scalar typeFixes: #564