Repository navigation
added tests for clickhouse database - #532
Conversation
Pull Request Test Coverage Report for Build 272
💛 - Coveralls |
| config *Config | ||
| conn *sql.DB | ||
| config *Config | ||
| isLocked bool |
There was a problem hiding this comment.
| t.Fatal(err) | ||
| } | ||
|
|
||
| if err := d.(*ClickHouse).ensureVersionTable(); err != nil { |
There was a problem hiding this comment.
Why is ensureVersionTable() called twice? Does it need to be called at all?
There was a problem hiding this comment.
yes, you right. I removed it, thanks
| @@ -0,0 +1,184 @@ | |||
| package clickhouse | |||
There was a problem hiding this comment.
this test included in the package clickhouse, not clichouse_test. Other databases tests included in databases packages too
There was a problem hiding this comment.
I didn't see any usage of unexported identifiers, but could have missed some. If we don't need to use unexported identifiers in tests, let's use a different package name for the tests and import the clickhouse package.
Other databases tests included in databases packages too
Some db tests test unexported methods. We should really split our tests into internal and external tests...
There was a problem hiding this comment.
I understood. Thanks, fixed
dhui
left a comment
dhui
left a comment
There was a problem hiding this comment.
Thanks for address the PR feedback!
3 participants
Hi!
I want added tests for clickhouse database