Skip to content

feat: add session id attribute on hook events#89

Merged
kenkalang merged 28 commits into
mainfrom
feature/add-session-id
Apr 13, 2026
Merged

feat: add session id attribute on hook events#89
kenkalang merged 28 commits into
mainfrom
feature/add-session-id

Conversation

@kenkalang

Copy link
Copy Markdown

Proposed Changes

Adding session id attribute to hook events. This will allow easier tracing or debugging a problem by identifying the specific session associated with each event.

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes issue #XXXX)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (correction or otherwise)
  • Cosmetics (whitespace, styles...)
  • DevOps (Build scripts, pipelines...)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating
the PR. If you're unsure about any of them, don't hesitate to ask on the
mailing list. We're here to help! This is simply a reminder of what we are
going to look for before merging your code.

  • I have read the CODE_OF_CONDUCT.md document
  • All tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if needed)
  • Any dependent changes have been merged and published in related repositories
  • I have updated changelog (At the bottom of the release version)
  • I have squashed all my commits into one before merging

Further Comments

If this is a relatively large or complex change, kick off the discussion by
explaining why you chose the solution you did and what alternatives you
considered, etc.

@kenkalang kenkalang force-pushed the feature/add-session-id branch 2 times, most recently from 8cdb907 to 42f4716 Compare March 5, 2026 20:16
Comment thread apps/vmq_enhanced_auth/src/vmq_enhanced_auth.erl Outdated
@kenkalang kenkalang force-pushed the feature/add-session-id branch from 3ad5e19 to d54a28d Compare March 23, 2026 09:34
Comment thread apps/vmq_server/src/vmq_mqtt_fsm.erl Outdated
@VivekPipaliya23

Copy link
Copy Markdown

Can we add an example/dummy sessionId in test cases?

@kenkalang kenkalang force-pushed the feature/add-session-id branch from 99dce01 to ec923b2 Compare March 30, 2026 09:52
Comment thread apps/vmq_server/src/vmq_mqtt_fsm.erl Outdated
Comment thread apps/vmq_server/src/vmq_mqtt_fsm.erl Outdated
Comment thread apps/vmq_server/src/vmq_queue.erl Outdated
@kenkalang kenkalang force-pushed the feature/add-session-id branch from 14e4fc7 to d796d54 Compare April 7, 2026 08:17
Comment thread apps/vmq_server/src/vmq_queue.erl Outdated
@kenkalang kenkalang force-pushed the feature/add-session-id branch from 47b8591 to e80c318 Compare April 9, 2026 08:53
VivekPipaliya23
VivekPipaliya23 previously approved these changes Apr 9, 2026
@kenkalang kenkalang force-pushed the feature/add-session-id branch from 4937679 to 1492ad6 Compare April 10, 2026 07:33
@kenkalang kenkalang merged commit 7d71a54 into main Apr 13, 2026
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants