Skip to content

feat: add on_register_failed hook#86

Merged
kenkalang merged 2 commits into
mainfrom
feature/enable-auth-on-register
Mar 30, 2026
Merged

feat: add on_register_failed hook#86
kenkalang merged 2 commits into
mainfrom
feature/enable-auth-on-register

Conversation

@kenkalang

@kenkalang kenkalang commented Feb 3, 2026

Copy link
Copy Markdown

Proposed Changes

This change contains creating on_register_failed hook event on sidecar plugin. This hook will capture client property and reason of failed register.
These are list of reasons on failed registration:

enum RegistrationFailureReason {
    REASON_UNSPECIFIED = 0;
    REASON_NO_MATCHING_HOOK_FOUND = 1;
    REASON_INVALID_CREDENTIALS = 2;
    REASON_NOT_AUTHORIZED = 3;
    REASON_STALE_REQUEST = 4;
    REASON_INVALID_SIGNATURE = 5;
    REASON_USERNAME_RID_MISMATCH = 6;
}

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes issue #XXXX)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (correction or otherwise)
  • Cosmetics (whitespace, styles...)
  • DevOps (Build scripts, pipelines...)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating
the PR. If you're unsure about any of them, don't hesitate to ask on the
mailing list. We're here to help! This is simply a reminder of what we are
going to look for before merging your code.

  • I have read the CODE_OF_CONDUCT.md document
  • All tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if needed)
  • Any dependent changes have been merged and published in related repositories
  • I have updated changelog (At the bottom of the release version)
  • I have squashed all my commits into one before merging

Further Comments

If this is a relatively large or complex change, kick off the discussion by
explaining why you chose the solution you did and what alternatives you
considered, etc.

Comment thread apps/vmq_enhanced_auth/src/vmq_enhanced_auth.erl Outdated
Comment thread apps/vmq_events_sidecar/src/vmq_events_sidecar_format.erl Outdated
@kenkalang kenkalang changed the title feat: enable auth_on_register on sidecar plugin feat: add on_register_failed hook Mar 3, 2026
@kenkalang kenkalang force-pushed the feature/enable-auth-on-register branch from d6c67f7 to 334b5b0 Compare March 4, 2026 07:34
Comment thread apps/vmq_server/src/vmq_metrics.erl
Comment thread apps/vmq_server/src/vmq_server.hrl Outdated
Comment thread apps/vmq_server/src/vmq_metrics.erl
Comment thread apps/vmq_server/src/vmq_server.hrl Outdated
@dhruvjain99

Copy link
Copy Markdown
Member

Please fix the failing ci

@kenkalang kenkalang force-pushed the feature/enable-auth-on-register branch 2 times, most recently from c2a7aba to 5cd2a1f Compare March 9, 2026 10:30
@kenkalang kenkalang changed the base branch from main to feature/add-session-id March 9, 2026 14:16
@kenkalang kenkalang force-pushed the feature/enable-auth-on-register branch from 5cd2a1f to 6d4a199 Compare March 23, 2026 08:45
@kenkalang kenkalang changed the base branch from feature/add-session-id to main March 23, 2026 08:47
@kenkalang kenkalang closed this Mar 23, 2026
@kenkalang kenkalang force-pushed the feature/enable-auth-on-register branch from 6d4a199 to 3edaa6f Compare March 23, 2026 08:51
@kenkalang kenkalang reopened this Mar 23, 2026
@kenkalang kenkalang force-pushed the feature/enable-auth-on-register branch 2 times, most recently from 5976d3b to 515a868 Compare March 23, 2026 09:19
dhruvjain99
dhruvjain99 previously approved these changes Mar 26, 2026
@kenkalang kenkalang force-pushed the feature/enable-auth-on-register branch from 515a868 to e109b28 Compare March 26, 2026 04:51
@kenkalang kenkalang merged commit 44cc76d into main Mar 30, 2026
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants