feat: add on_register_failed hook#86
Merged
Merged
Conversation
dhruvjain99
requested changes
Feb 13, 2026
d6c67f7 to
334b5b0
Compare
VivekPipaliya23
requested changes
Mar 5, 2026
Member
|
Please fix the failing ci |
c2a7aba to
5cd2a1f
Compare
5cd2a1f to
6d4a199
Compare
6d4a199 to
3edaa6f
Compare
5976d3b to
515a868
Compare
dhruvjain99
previously approved these changes
Mar 26, 2026
515a868 to
e109b28
Compare
VivekPipaliya23
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
This change contains creating on_register_failed hook event on sidecar plugin. This hook will capture client property and reason of failed register.
These are list of reasons on failed registration:
Types of Changes
What types of changes does your code introduce to this project?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creatingthe PR. If you're unsure about any of them, don't hesitate to ask on the
mailing list. We're here to help! This is simply a reminder of what we are
going to look for before merging your code.
CODE_OF_CONDUCT.mddocumentFurther Comments
If this is a relatively large or complex change, kick off the discussion by
explaining why you chose the solution you did and what alternatives you
considered, etc.