Skip to content

Fix offline store choking by bypassing plugin for redis ops#63

Merged
dhruvjain99 merged 7 commits into
mainfrom
fix/offline-store-choking
May 14, 2024
Merged

Fix offline store choking by bypassing plugin for redis ops#63
dhruvjain99 merged 7 commits into
mainfrom
fix/offline-store-choking

Conversation

@dhruvjain99

Copy link
Copy Markdown
Member

Proposed Changes

Bypasses offline store plugin for message store operations on redis. This prevents the HOL blocking of message store operations which was happening in the plugin process.

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes issue #XXXX)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (correction or otherwise)
  • Cosmetics (whitespace, styles...)
  • DevOps (Build scripts, pipelines...)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating
the PR. If you're unsure about any of them, don't hesitate to ask on the
mailing list. We're here to help! This is simply a reminder of what we are
going to look for before merging your code.

  • I have read the CODE_OF_CONDUCT.md document
  • All tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if needed)
  • Any dependent changes have been merged and published in related repositories
  • I have updated changelog (At the bottom of the release version)
  • I have squashed all my commits into one before merging

Comment thread apps/vmq_server/src/vmq_message_store.erl Outdated
@dhruvjain99 dhruvjain99 merged commit 6637ce4 into main May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants