Skip to content

Feat: add new plugin for metrics#53

Merged
dhruvjain99 merged 11 commits into
mainfrom
feat/introduce-new-metrics-plugin
Apr 29, 2024
Merged

Feat: add new plugin for metrics#53
dhruvjain99 merged 11 commits into
mainfrom
feat/introduce-new-metrics-plugin

Conversation

@VivekPipaliya23

Copy link
Copy Markdown

Proposed Changes

This PR will add a new verneMQ plugin named vmq_metrics_plus for metrics and observability instrumentations. Topic-level metrics are moved in this new plugin.

Types of Changes

  • Bugfix (non-breaking change which fixes issue #XXXX)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (correction or otherwise)
  • Cosmetics (whitespace, styles...)
  • DevOps (Build scripts, pipelines...)

Checklist

  • I have read the CODE_OF_CONDUCT.md document
  • All tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if needed)
  • Any dependent changes have been merged and published in related repositories
  • I have updated changelog (At the bottom of the release version)
  • I have squashed all my commits into one before merging

@dhruvjain99 dhruvjain99 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure your pipeline passes. And then only make the PR ready to be reviewed. In all other cases keep it WIP.

Comment thread apps/vmq_metrics_plus/src/vmq_metrics_plus.erl Outdated
Comment thread apps/vmq_metrics_plus/src/vmq_metrics_plus_sup.erl Outdated
@VivekPipaliya23 VivekPipaliya23 force-pushed the feat/introduce-new-metrics-plugin branch from b6a0eea to 0bdbc93 Compare April 17, 2024 08:53
Comment thread apps/vmq_events_sidecar/src/vmq_events_sidecar_plugin.erl
Comment thread apps/vmq_events_sidecar/test/vmq_events_sidecar_SUITE.erl
Comment thread apps/vmq_metrics_plus/src/vmq_metrics_plus_plugin.erl Outdated
Comment thread rebar.config
@dhruvjain99 dhruvjain99 merged commit c55ae9b into main Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants