Skip to content

fix: warning level for unexpected frame log#46

Merged
dhruvjain99 merged 1 commit into
mainfrom
fix/unexpected-frame-log-level-warning
Feb 20, 2024
Merged

fix: warning level for unexpected frame log#46
dhruvjain99 merged 1 commit into
mainfrom
fix/unexpected-frame-log-level-warning

Conversation

@dhruvjain99

Copy link
Copy Markdown
Member

Proposed Changes

Any disconnection from the broker due to unexpected frame type must be caught. At present log level for unexpected message log is warning. Changing it to error in order to capture it in production.

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes issue #XXXX)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (correction or otherwise)
  • Cosmetics (whitespace, styles...)
  • DevOps (Build scripts, pipelines...)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating
the PR. If you're unsure about any of them, don't hesitate to ask on the
mailing list. We're here to help! This is simply a reminder of what we are
going to look for before merging your code.

  • I have read the CODE_OF_CONDUCT.md document
  • All tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if needed)
  • Any dependent changes have been merged and published in related repositories
  • I have updated changelog (At the bottom of the release version)
  • I have squashed all my commits into one before merging

@VivekPipaliya23 VivekPipaliya23 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dhruvjain99 dhruvjain99 merged commit 8352c4b into main Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants