feat: add topic level sampling with on_deliver event#44
Merged
dhruvjain99 merged 3 commits intoFeb 19, 2024
Conversation
2d3b314 to
455e617
Compare
6e04ef2 to
dced388
Compare
455e617 to
42aac47
Compare
dhruvjain99
requested changes
Feb 12, 2024
42aac47 to
834bb1b
Compare
dhruvjain99
previously approved these changes
Feb 14, 2024
6903fd3 to
7765db1
Compare
7765db1 to
cc5ffea
Compare
dhruvjain99
approved these changes
Feb 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
This MR adds the capability to enable/disable hook events based on acl_name for on_deliver.
Types of Changes
What types of changes does your code introduce to this project?
Put an
xin the boxes that applyChecklist
CODE_OF_CONDUCT.mddocument