Skip to content

feat: add topic level sampling with on_deliver event#44

Merged
dhruvjain99 merged 3 commits into
mainfrom
feat/topic-level-sampling-with-on-deliver-event
Feb 19, 2024
Merged

feat: add topic level sampling with on_deliver event#44
dhruvjain99 merged 3 commits into
mainfrom
feat/topic-level-sampling-with-on-deliver-event

Conversation

@VivekPipaliya23

Copy link
Copy Markdown

Proposed Changes

This MR adds the capability to enable/disable hook events based on acl_name for on_deliver.

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes issue #XXXX)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (correction or otherwise)
  • Cosmetics (whitespace, styles...)
  • DevOps (Build scripts, pipelines...)

Checklist

  • I have read the CODE_OF_CONDUCT.md document
  • All tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if needed)
  • Any dependent changes have been merged and published in related repositories
  • I have updated changelog (At the bottom of the release version)
  • I have squashed all my commits into one before merging

@VivekPipaliya23 VivekPipaliya23 force-pushed the feat/topic-level-sampling-with-on-deliver-event branch from 2d3b314 to 455e617 Compare February 9, 2024 08:25
@VivekPipaliya23 VivekPipaliya23 force-pushed the feat/add-topic-metrics-to-on-deliver-and-complete-events branch from 6e04ef2 to dced388 Compare February 9, 2024 08:26
@VivekPipaliya23 VivekPipaliya23 force-pushed the feat/topic-level-sampling-with-on-deliver-event branch from 455e617 to 42aac47 Compare February 9, 2024 12:16
Comment thread apps/vmq_events_sidecar/priv/vmq_events_sidecar.schema Outdated
Comment thread apps/vmq_events_sidecar/src/vmq_events_sidecar_cli.erl Outdated
@VivekPipaliya23 VivekPipaliya23 force-pushed the feat/topic-level-sampling-with-on-deliver-event branch from 42aac47 to 834bb1b Compare February 12, 2024 18:27
dhruvjain99
dhruvjain99 previously approved these changes Feb 14, 2024
@dhruvjain99 dhruvjain99 changed the base branch from feat/add-topic-metrics-to-on-deliver-and-complete-events to main February 16, 2024 06:22
@dhruvjain99 dhruvjain99 dismissed their stale review February 16, 2024 06:22

The base branch was changed.

@dhruvjain99 dhruvjain99 changed the base branch from main to feat/add-topic-metrics-to-on-deliver-and-complete-events February 16, 2024 06:31
@VivekPipaliya23 VivekPipaliya23 force-pushed the feat/topic-level-sampling-with-on-deliver-event branch from 6903fd3 to 7765db1 Compare February 16, 2024 06:39
@VivekPipaliya23 VivekPipaliya23 changed the base branch from feat/add-topic-metrics-to-on-deliver-and-complete-events to main February 16, 2024 06:42
@VivekPipaliya23 VivekPipaliya23 force-pushed the feat/topic-level-sampling-with-on-deliver-event branch from 7765db1 to cc5ffea Compare February 16, 2024 07:02
@dhruvjain99 dhruvjain99 merged commit fac52eb into main Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants