feat: add topic level metrics with ACL matching#35
Merged
Conversation
dhruvjain99
requested changes
Jan 11, 2024
dhruvjain99
requested changes
Jan 12, 2024
dhruvjain99
requested changes
Jan 13, 2024
dhruvjain99
requested changes
Jan 13, 2024
dhruvjain99
reviewed
Jan 18, 2024
cb9e6f7 to
916f3ed
Compare
916f3ed to
5638f66
Compare
Member
|
It looks good but there is one issue. I can see the warnings below while running the unit tests. Please find out the tests for which it is happening and the reason as well. Ideally these warning shouldn't be there. |
dhruvjain99
approved these changes
Jan 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Adding Metrics on various levels of Topics by adding labels to ACL definition in enhanced auth plugin.
Types of Changes
What types of changes does your code introduce to this project?
Put an
xin the boxes that apply