Skip to content

feat: add topic level metrics with ACL matching#35

Merged
dhruvjain99 merged 11 commits into
mainfrom
feat/add-topic-level-metrics
Jan 22, 2024
Merged

feat: add topic level metrics with ACL matching#35
dhruvjain99 merged 11 commits into
mainfrom
feat/add-topic-level-metrics

Conversation

@VivekPipaliya23

Copy link
Copy Markdown

Proposed Changes

Adding Metrics on various levels of Topics by adding labels to ACL definition in enhanced auth plugin.

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes issue #XXXX)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (correction or otherwise)
  • Cosmetics (whitespace, styles...)
  • DevOps (Build scripts, pipelines...)

@VivekPipaliya23 VivekPipaliya23 self-assigned this Dec 8, 2023
Comment thread apps/vmq_server/src/vmq_metrics.erl
Comment thread apps/vmq_server/src/vmq_metrics.erl Outdated
Comment thread apps/vmq_server/src/vmq_metrics.erl Outdated
Comment thread apps/vmq_server/src/vmq_metrics.erl Outdated
Comment thread apps/vmq_server/src/vmq_metrics.erl
Comment thread apps/vmq_enhanced_auth/src/vmq_enhanced_auth.erl
Comment thread apps/vmq_enhanced_auth/src/vmq_enhanced_auth.erl Outdated
Comment thread apps/vmq_enhanced_auth/src/vmq_enhanced_auth.erl Outdated
Comment thread apps/vmq_enhanced_auth/src/vmq_enhanced_auth.erl Outdated
Comment thread apps/vmq_enhanced_auth/src/vmq_enhanced_auth.erl Outdated
Comment thread apps/vmq_enhanced_auth/src/vmq_enhanced_auth.erl
Comment thread apps/vmq_enhanced_auth/src/vmq_enhanced_auth.erl
Comment thread apps/vmq_enhanced_auth/src/vmq_enhanced_auth.erl Outdated
Comment thread apps/vmq_enhanced_auth/src/vmq_enhanced_auth.erl Outdated
Comment thread apps/vmq_enhanced_auth/src/vmq_enhanced_auth.erl Outdated
Comment thread apps/vmq_enhanced_auth/src/vmq_enhanced_auth.erl Outdated
Comment thread apps/vmq_server/src/vmq_metrics.erl Outdated
@VivekPipaliya23 VivekPipaliya23 force-pushed the feat/add-topic-level-metrics branch from cb9e6f7 to 916f3ed Compare January 18, 2024 05:18
@VivekPipaliya23 VivekPipaliya23 force-pushed the feat/add-topic-level-metrics branch from 916f3ed to 5638f66 Compare January 18, 2024 05:42
@dhruvjain99

dhruvjain99 commented Jan 18, 2024

Copy link
Copy Markdown
Member

It looks good but there is one issue. I can see the warnings below while running the unit tests.
Ref: https://github.com/gojek/vernemq/actions/runs/7565865328/job/20602360570?pr=35#step:10:336

Please find out the tests for which it is happening and the reason as well. Ideally these warning shouldn't be there.
@VivekPipaliya23

dhruvjain99
dhruvjain99 previously approved these changes Jan 22, 2024

@dhruvjain99 dhruvjain99 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dhruvjain99 dhruvjain99 merged commit 6559637 into main Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants