Skip to content

Local shared subscriber's routing cache#22

Merged
dhruvjain99 merged 15 commits into
mainfrom
spike-shared-subs-local
May 4, 2023
Merged

Local shared subscriber's routing cache#22
dhruvjain99 merged 15 commits into
mainfrom
spike-shared-subs-local

Conversation

@ajatprabha

@ajatprabha ajatprabha commented Apr 11, 2023

Copy link
Copy Markdown
Member

Proposed Changes

Cache the message routing of shared subscribers in-memory.

Types of Changes

  • Bugfix (non-breaking change which fixes issue #XXXX)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (correction or otherwise)
  • Cosmetics (whitespace, styles...)
  • DevOps (Build scripts, pipelines...)

Checklist

  • I have read the CODE_OF_CONDUCT.md document
  • All tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if needed)
  • Any dependent changes have been merged and published in related repositories
  • I have updated changelog (At the bottom of the release version)
  • I have squashed all my commits into one before merging

Further Comments

Local shared subscriptions currently do not honor shared subscription groups properly.
It is recommended to use shared subscription topics only for shared subscription use-cases. Do not expect broker to route msgs for same topic to both shared subscribers and normal subscribers. It will only route to shared subscribers irrespective of shared subscription groups.

@ajatprabha ajatprabha force-pushed the spike-shared-subs-local branch 2 times, most recently from 6ee2b49 to 455152d Compare April 18, 2023 11:18
@ajatprabha ajatprabha force-pushed the spike-shared-subs-local branch from 455152d to c450086 Compare April 20, 2023 08:55
Comment thread apps/vmq_commons/src/packet.erl Outdated
Comment thread apps/vmq_server/src/vmq_reg.erl Outdated
Comment thread apps/vmq_server/src/vmq_reg.erl
Comment thread apps/vmq_server/test/mqtt5_v4compat.erl
Comment thread apps/vmq_server/test/vmq_cluster_SUITE.erl
Comment thread apps/vmq_server/test/vmq_cluster_SUITE.erl
@ajatprabha ajatprabha changed the title [WIP] Local shared subscriber's routing cache Local shared subscriber's routing cache May 4, 2023
@dhruvjain99 dhruvjain99 merged commit 3e96296 into main May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants