Build history by kofj · Pull Request #5371 · goharbor/harbor

kofj · 2018-07-23T14:52:13Z

Show build history info in the tag detail page as a default table panel.

vmwclabot · 2018-07-23T14:52:19Z

@kofj, you must sign our contributor license agreement before your changes are merged. Click here to sign the agreement. If you are a VMware employee, read this for further instruction.

coveralls · 2018-07-23T15:40:36Z

Pull Request Test Coverage Report for Build 7786

0 of 0 changed or added relevant lines in 0 files are covered.
161 unchanged lines in 5 files lost coverage.
Overall coverage decreased (-0.2%) to 63.662%

Files with Coverage Reduction	New Missed Lines	%
src/jobservice/period/enqueuer.go	1	79.17%
src/common/scheduler/policy/alternate_policy.go	3	80.29%
src/chartserver/chart_operator.go	9	77.06%
src/chartserver/utils.go	21	39.39%
src/ui/api/chart_repository.go	127	0.0%

Totals
Change from base Build 7734:	-0.2%
Covered Lines:	11913
Relevant Lines:	18713

💛 - Coveralls

vmwclabot · 2018-07-23T18:22:03Z

@kofj, VMware has approved your signed contributor license agreement.

steven-zou

Some minor comments

steven-zou · 2018-07-25T03:30:41Z

+  public getManifest(
+    repositoryName: string,
+    tag: string,
+    queryParams?: RequestQueryParams


The optional 'queryParams' is not appended to the request. If caller pass parameters, it will be no effect

This optional is not used, should be removed.

steven-zou · 2018-07-25T03:31:35Z

 } from '../utils';
 import { ErrorHandler } from '../error-handler/index';
-import { SystemSettingsComponent, VulnerabilityConfigComponent } from './index';
+import { SystemSettingsComponent } from './system/system-settings.component';


What's the reason of changing the importing paths of these components

Because it will warn: "Circular dependency" when running NG Live Development Server.

steven-zou · 2018-07-25T08:47:39Z

-                        <div><clr-icon shape="play" size="20" class="tip-icon-low rotate-90"></clr-icon>{{lowCount}} {{'VULNERABILITY.SEVERITY.LOW' | translate }}&nbsp;{{'TAG.LEVEL_VULNERABILITIES' | translate }}</div>
-                        <div class="second-row"><clr-icon shape="help" size="18"></clr-icon>{{unknownCount}} {{'VULNERABILITY.SEVERITY.UNKNOWN' | translate }}&nbsp;{{'TAG.LEVEL_VULNERABILITIES' | translate }}</div>
+                        <div>
+                            <clr-icon shape="error" size="24" class="is-error"></clr-icon> {{highCount}} {{'VULNERABILITY.SEVERITY.HIGH' | translate }}&nbsp;{{'TAG.LEVEL_VULNERABILITIES'


Seems this part is only code formatting changes. But the format is a little inconsistent with the original style.

It is an error, will be fixed later.

steven-zou · 2018-07-25T08:49:14Z

-import {JobLogViewerComponent} from "../job-log-viewer/job-log-viewer.component";
-import {ChannelService} from "../channel/channel.service";
-import {JobLogService, JobLogDefaultService} from "../service/job-log.service";
+import { VULNERABILITY_DIRECTIVES } from "../vulnerability-scanning/index";


Good format!

steven-zou · 2018-08-27T04:43:16Z

@kofj

Let' holding for a while and merge it into master after @ninjadq and @zhoumeina complete the upgrading work of Clarity and Angular.

Rebase will be required then!

steven-zou · 2018-09-12T05:13:21Z

@kofj

The related libraries of front-end UI are upgraded to new versions (Angular to 6.x, clarity to 0.12). Now we can start the merging work of this PR. Before doing that, I think you need to rebase your code to based on the new code base. Once you have done, please let us know.

ghost · 2018-10-03T13:48:10Z

Hi @kofj – please rebase when you get a moment. Thanks!

kofj · 2018-10-15T23:30:23Z

@steven-zou @ninjadq All checks have passed, review please.

coveralls · 2018-10-16T22:49:21Z

Pull Request Test Coverage Report for Build 9145

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.02%) to 64.655%

Totals
Change from base Build 9144:	0.02%
Covered Lines:	12600
Relevant Lines:	19488

💛 - Coveralls

zhoumeina · 2018-10-22T01:30:01Z

@@ -0,0 +1,11 @@
+<clr-datagrid [clrDgLoading]="loading">
+    <clr-dg-column style="width: 160px;">{{ 'TAG.CREATION' | translate }}</clr-dg-column>


Please move this style="width: 160px;" to scss.

zhoumeina · 2018-10-22T01:46:39Z

@kofj , I don't know why when I try to create some comments, it returns 405 not allowed.

zhoumeina

Please modify according to the comment.

zhoumeina

Please modify according to the comment.

zhoumeina · 2018-10-23T00:43:16Z

-    "RUNNING":"执行中",
-    "ERROR":"错误",
+    "STATUS": "状态",
+    "START_TIME": "开始时间",


why need to modify this update_time to endtime. It should not be modified in this pr.

zhoumeina

Please change it according to comment.

zhoumeina

LGTM

Add build histroy section and navbar to tag-detail component Add i18n items of build history Format code. Signed-off-by: Frank Kung <kfanjian@gmail.com>

Move style to scss file. Signed-off-by: Frank Kung <kfanjian@gmail.com>

reasonerjt requested a review from steven-zou July 24, 2018 02:47

reasonerjt assigned steven-zou Jul 24, 2018

steven-zou assigned ninjadq Jul 25, 2018

steven-zou requested a review from ninjadq July 25, 2018 08:33

steven-zou reviewed Jul 25, 2018

View reviewed changes

reasonerjt added the 1.6.0-defer label Aug 2, 2018

reasonerjt assigned steven-zou and ninjadq and unassigned ninjadq and steven-zou Aug 8, 2018

reasonerjt added target/1.7.0 Work items that should be delivered in 1.7.0 timeframe. and removed 1.6.0-defer labels Aug 31, 2018

reasonerjt added this to the Sprint 44 milestone Sep 18, 2018

reasonerjt modified the milestones: Sprint 44, Sprint 45 Oct 9, 2018

kofj closed this Oct 12, 2018

kofj reopened this Oct 15, 2018

steven-zou requested a review from zhoumeina October 22, 2018 01:10

steven-zou assigned zhoumeina Oct 22, 2018

zhoumeina reviewed Oct 22, 2018

View reviewed changes

zhoumeina self-requested a review October 22, 2018 01:42

zhoumeina self-requested a review October 22, 2018 01:47

zhoumeina approved these changes Oct 22, 2018

View reviewed changes

zhoumeina suggested changes Oct 22, 2018

View reviewed changes

zhoumeina reviewed Oct 23, 2018

View reviewed changes

zhoumeina suggested changes Oct 23, 2018

View reviewed changes

zhoumeina approved these changes Oct 23, 2018

View reviewed changes

kofj added 2 commits October 23, 2018 16:10

Add build history component to Harbor UI

fd9e3dc

Add build histroy section and navbar to tag-detail component Add i18n items of build history Format code. Signed-off-by: Frank Kung <kfanjian@gmail.com>

Add unit test of build history section.

735ae1b

Move style to scss file. Signed-off-by: Frank Kung <kfanjian@gmail.com>

steven-zou merged commit 04e9190 into goharbor:master Oct 24, 2018

steven-zou mentioned this pull request Dec 21, 2018

nominate @kofj as harbor maintainer goharbor/community#31

Merged

		@@ -0,0 +1,11 @@
		<clr-datagrid [clrDgLoading]="loading">
		<clr-dg-column style="width: 160px;">{{ 'TAG.CREATION' \| translate }}</clr-dg-column>

Conversation

kofj commented Jul 23, 2018

Uh oh!

vmwclabot commented Jul 23, 2018

Uh oh!

coveralls commented Jul 23, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Test Coverage Report for Build 7786

💛 - Coveralls

Uh oh!

vmwclabot commented Jul 23, 2018

Uh oh!

steven-zou left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

steven-zou commented Aug 27, 2018

Uh oh!

steven-zou commented Sep 12, 2018

Uh oh!

ghost commented Oct 3, 2018

Uh oh!

kofj commented Oct 15, 2018

Uh oh!

coveralls commented Oct 16, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Test Coverage Report for Build 9145

💛 - Coveralls

Uh oh!

zhoumeina Oct 22, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

zhoumeina commented Oct 22, 2018

Uh oh!

zhoumeina left a comment

Choose a reason for hiding this comment

Uh oh!

zhoumeina left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

zhoumeina left a comment

Choose a reason for hiding this comment

Uh oh!

zhoumeina left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

coveralls commented Jul 23, 2018 •

edited

Loading

coveralls commented Oct 16, 2018 •

edited

Loading

zhoumeina Oct 22, 2018 •

edited

Loading