(cherry-pick) Update Makefile PIP_INDEX_URL to use default value if not defined - #23377
Merged
Merged
Conversation
Signed-off-by: stonezdj <stone.zhang@broadcom.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-2.15.0 #23377 +/- ##
=================================================
Coverage ? 66.01%
=================================================
Files ? 1073
Lines ? 116682
Branches ? 2952
=================================================
Hits ? 77024
Misses ? 35384
Partials ? 4274
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
build: support custom PyPI index URL for prepare image builds Pass PIP_INDEX_URL through the make build chain as a Docker --build-arg, mirroring the existing NPM_REGISTRY pattern for the portal build. Signed-off-by: stonezdj <stone.zhang@broadcom.com>
stonezdj
changed the title
Contributor
|
I believe this should be also cherry pick to branch 2.14, thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to Harbor!
Comprehensive Summary of your change
Issue being fixed
Fixes #(issue)
Please indicate you've done the following: