Skip to content

Make openapi-generator-cli download URL configurable - #23186

Merged
stonezdj merged 1 commit into
goharbor:mainfrom
stonezdj:26apr30_update_download_url
May 1, 2026
Merged

Make openapi-generator-cli download URL configurable#23186
stonezdj merged 1 commit into
goharbor:mainfrom
stonezdj:26apr30_update_download_url

Conversation

@stonezdj

Copy link
Copy Markdown
Contributor

Add OPENAPI_GENERATOR_CLI_URL (default: Maven Central) so swagger_client can use a mirror or cache when repo1.maven.org returns 429.

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@stonezdj
stonezdj requested a review from a team as a code owner April 30, 2026 02:58
@codecov

codecov Bot commented Apr 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.02%. Comparing base (88ab662) to head (23859e3).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #23186      +/-   ##
==========================================
- Coverage   66.02%   66.02%   -0.01%     
==========================================
  Files        1074     1074              
  Lines      116793   116793              
  Branches     2955     2955              
==========================================
- Hits        77114    77111       -3     
- Misses      35406    35409       +3     
  Partials     4273     4273              
Flag Coverage Δ
unittests 66.02% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 8 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@stonezdj
stonezdj force-pushed the 26apr30_update_download_url branch 2 times, most recently from e7b438f to 4894e72 Compare April 30, 2026 05:32

@wy65701436 wy65701436 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@stonezdj stonezdj added the release-note/ignore-for-release Do not include PR or Issue for release notes label Apr 30, 2026
@stonezdj
stonezdj requested a review from fiona-xie April 30, 2026 05:58
@fiona-xie

Copy link
Copy Markdown
Contributor

Why the API DB cases are still failed?

@stonezdj
stonezdj force-pushed the 26apr30_update_download_url branch 4 times, most recently from 41cb5f6 to 924708e Compare April 30, 2026 07:26
Add OPENAPI_GENERATOR_CLI_URL (default: Maven Central) so swagger_client
can use a mirror or cache when repo1.maven.org returns 429.
Append the HARBOR_EXPORTER_CACHE_TIME variable to the env file with new line

Signed-off-by: stonezdj <stone.zhang@broadcom.com>

fix issue

Signed-off-by: stonezdj <stone.zhang@broadcom.com>
@stonezdj
stonezdj force-pushed the 26apr30_update_download_url branch from 924708e to 23859e3 Compare April 30, 2026 09:42

@jUDASmILE jUDASmILE left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@stonezdj
stonezdj merged commit 62c278d into goharbor:main May 1, 2026
12 checks passed
chlins pushed a commit to chlins/harbor that referenced this pull request May 9, 2026
Signed-off-by: chlins <chlins.zhang@gmail.com>
chlins pushed a commit to chlins/harbor that referenced this pull request May 9, 2026
Signed-off-by: chlins <chlins.zhang@gmail.com>
wy65701436 pushed a commit that referenced this pull request May 10, 2026
…23186) (#23221)

Make openapi-generator-cli download URL configurable (#23186)

Signed-off-by: chlins <chlins.zhang@gmail.com>
Co-authored-by: stonezdj(Daojun Zhang) <stonezdj@gmail.com>
wy65701436 pushed a commit that referenced this pull request May 11, 2026
…23186) (#23222)

Make openapi-generator-cli download URL configurable (#23186)

Signed-off-by: chlins <chlins.zhang@gmail.com>
Co-authored-by: stonezdj(Daojun Zhang) <stonezdj@gmail.com>
bupd added a commit to container-registry/harbor-next that referenced this pull request Jun 11, 2026
Upstream-PR: goharbor/harbor#23186

Upstream-Author: @stonezdj
Signed-off-by: Prasanth Baskar <bupdprasanth@gmail.com>
bupd added a commit to container-registry/harbor-next that referenced this pull request Jun 23, 2026
Upstream-PR: goharbor/harbor#23186

Upstream-Author: @stonezdj
Co-authored-by: Prasanth Baskar <bupdprasanth@gmail.com>
Signed-off-by: stonezdj(Daojun Zhang) <stonezdj@gmail.com>
Signed-off-by: Prasanth Baskar <bupdprasanth@gmail.com>
bupd added a commit to container-registry/harbor-next that referenced this pull request Jun 23, 2026
Upstream-PR: goharbor/harbor#23186

Upstream-Author: @stonezdj

Signed-off-by: Prasanth Baskar <bupdprasanth@gmail.com>
bupd added a commit to container-registry/harbor-next that referenced this pull request Jun 23, 2026
Upstream-PR: goharbor/harbor#23186

Upstream-Author: @stonezdj
Co-authored-by: Prasanth Baskar <bupdprasanth@gmail.com>
Signed-off-by: stonezdj(Daojun Zhang) <stonezdj@gmail.com>
Signed-off-by: Prasanth Baskar <bupdprasanth@gmail.com>
bupd added a commit to container-registry/harbor-next that referenced this pull request Jun 23, 2026
Upstream-PR: goharbor/harbor#23186

Upstream-Author: @stonezdj
Co-authored-by: Prasanth Baskar <bupdprasanth@gmail.com>
Signed-off-by: stonezdj(Daojun Zhang) <stonezdj@gmail.com>
Signed-off-by: Prasanth Baskar <bupdprasanth@gmail.com>
bupd added a commit to container-registry/harbor-next that referenced this pull request Jul 2, 2026
Upstream-PR: goharbor/harbor#23186

Upstream-Author: @stonezdj
Co-authored-by: Prasanth Baskar <bupdprasanth@gmail.com>
Signed-off-by: stonezdj(Daojun Zhang) <stonezdj@gmail.com>
Signed-off-by: Prasanth Baskar <bupdprasanth@gmail.com>
(cherry picked from commit 06fc5d8)
Signed-off-by: Prasanth Baskar <bupdprasanth@gmail.com>
bupd added a commit to container-registry/harbor-next that referenced this pull request Jul 3, 2026
Upstream-PR: goharbor/harbor#23186

Upstream-Author: @stonezdj
Co-authored-by: Prasanth Baskar <bupdprasanth@gmail.com>
Signed-off-by: stonezdj(Daojun Zhang) <stonezdj@gmail.com>
Signed-off-by: Prasanth Baskar <bupdprasanth@gmail.com>
(cherry picked from commit 06fc5d8)
Signed-off-by: Prasanth Baskar <bupdprasanth@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-note/ignore-for-release Do not include PR or Issue for release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants