Skip to content

Conversation

@chethanm99
Copy link
Contributor

@chethanm99 chethanm99 commented Jun 15, 2025

Fixes #22083

This PR enhances the CONTRIBUTING.md file by fixing some minor errors and enhancing readability.

@chethanm99 chethanm99 requested a review from a team as a code owner June 15, 2025 03:48
@Vad1mo
Copy link
Member

Vad1mo commented Jun 15, 2025

@chethanm99 please use the PR template

@Vad1mo Vad1mo added the release-note/docs Docs changes(made and needed) label Jun 15, 2025
@Vad1mo
Copy link
Member

Vad1mo commented Jun 15, 2025

@chethanm99 remove the .gitignore change, as it is in the other PR

@codecov
Copy link

codecov bot commented Jun 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.86%. Comparing base (c8c11b4) to head (ed4c057).
Report is 489 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main   #22082       +/-   ##
===========================================
+ Coverage   45.36%   65.86%   +20.49%     
===========================================
  Files         244     1071      +827     
  Lines       13333   115788   +102455     
  Branches     2719     2925      +206     
===========================================
+ Hits         6049    76259    +70210     
- Misses       6983    35298    +28315     
- Partials      301     4231     +3930     
Flag Coverage Δ
unittests 65.86% <ø> (+20.49%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 985 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@chethanm99 chethanm99 force-pushed the update_contributing.md branch from ed4c057 to a4b77c2 Compare June 15, 2025 07:47
@chethanm99 chethanm99 force-pushed the update_contributing.md branch from a4b77c2 to 6f4ee51 Compare June 15, 2025 08:01
@chethanm99
Copy link
Contributor Author

@Vad1mo Thanks for the feedback. I've used the PR template and removed the previous PR commit. Please let me know if there are any further changes.

Copy link
Contributor

@MinerYang MinerYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chlins chlins enabled auto-merge (squash) June 16, 2025 08:58
@chlins chlins merged commit f46ef3b into goharbor:main Jun 16, 2025
10 checks passed
@chethanm99 chethanm99 deleted the update_contributing.md branch June 16, 2025 09:39
OrlinVasilev pushed a commit to OrlinVasilev/harbor that referenced this pull request Oct 29, 2025
Fix minor errors in CONTRIBUTING.md

Signed-off-by: chethanm99 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-note/docs Docs changes(made and needed)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Minor grammatical errors in CONTRIBUTING.md

5 participants