Skip to content

Conversation

@bupd
Copy link
Contributor

@bupd bupd commented Jun 13, 2025

Comprehensive Summary of your change

This PR only adds validation for CVE Allowlist and does not impact any logic.

  • fixes validation for empty and cves with only spaces
  • Added Tests

2025-06-13_22-39-56

Issue being fixed

Fixes #21882

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/update"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@bupd bupd requested a review from a team as a code owner June 13, 2025 16:12
@codecov
Copy link

codecov bot commented Jun 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.86%. Comparing base (c8c11b4) to head (84053da).
Report is 491 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main   #22077       +/-   ##
===========================================
+ Coverage   45.36%   65.86%   +20.50%     
===========================================
  Files         244     1071      +827     
  Lines       13333   115799   +102466     
  Branches     2719     2925      +206     
===========================================
+ Hits         6049    76276    +70227     
- Misses       6983    35291    +28308     
- Partials      301     4232     +3931     
Flag Coverage Δ
unittests 65.86% <100.00%> (+20.50%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/pkg/allowlist/validator.go 90.90% <100.00%> (ø)
...eft-side-nav/config/security/security.component.ts 60.25% <100.00%> (+16.25%) ⬆️
...t-policy-config/project-policy-config.component.ts 52.65% <100.00%> (+3.90%) ⬆️
src/portal/src/app/shared/services/interface.ts 72.72% <ø> (ø)

... and 981 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bupd
Copy link
Contributor Author

bupd commented Jun 13, 2025

/label "release-note/update", "area/ui"

@stonezdj
Copy link
Contributor

@bupd could you please squash all commits together?

- fixes empty and cves with only spaces

Signed-off-by: bupd <[email protected]>

fix: cve allowlist validation

Signed-off-by: bupd <[email protected]>

add: tests for cve allowlist validation

Signed-off-by: bupd <[email protected]>

fix: types for projectCVEAllowlist

Signed-off-by: bupd <[email protected]>
@stonezdj stonezdj merged commit ec9d13d into goharbor:main Jun 17, 2025
12 checks passed
OrlinVasilev pushed a commit to OrlinVasilev/harbor that referenced this pull request Oct 29, 2025
fix: empty cve allowlist validation

- fixes empty and cves with only spaces



fix: cve allowlist validation



add: tests for cve allowlist validation



fix: types for projectCVEAllowlist

Signed-off-by: bupd <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CVE Allowlist should not allow empty cve.

5 participants