Skip to content

Conversation

@chlins
Copy link
Member

@chlins chlins commented Jun 4, 2025

This pull request includes a minor update to the .github/workflows/CI.yml file to fix a configuration issue with the Codecov action. The change updates the file parameter to the correct files parameter in two places, ensuring compatibility with the Codecov action's expected input.

CI workflow configuration updates:

  • .github/workflows/CI.yml: Changed file to files in the Codecov configuration for the backend coverage report (profile.cov) to align with the expected parameter name.
  • .github/workflows/CI.yml: Changed file to files in the Codecov configuration for the UI coverage report (lcov.info) to align with the expected parameter name.

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@chlins chlins requested a review from a team as a code owner June 4, 2025 04:33
@chlins chlins added the release-note/update Update or Fix label Jun 4, 2025
@codecov
Copy link

codecov bot commented Jun 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.85%. Comparing base (c8c11b4) to head (3cea81d).
Report is 486 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main   #22050       +/-   ##
===========================================
+ Coverage   45.36%   65.85%   +20.48%     
===========================================
  Files         244     1072      +828     
  Lines       13333   115791   +102458     
  Branches     2719     2925      +206     
===========================================
+ Hits         6049    76251    +70202     
- Misses       6983    35310    +28327     
- Partials      301     4230     +3929     
Flag Coverage Δ
unittests 65.85% <ø> (+20.48%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 985 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chlins chlins enabled auto-merge (squash) June 7, 2025 02:19
@chlins chlins merged commit f46295a into goharbor:main Jun 7, 2025
12 checks passed
OrlinVasilev pushed a commit to OrlinVasilev/harbor that referenced this pull request Oct 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-note/update Update or Fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants