increase docker client timeout for robot case #21994
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: my036811 <[email protected]>
|
@MinerYang is there an issue regarding this PR? any particular need for that change ? we need to provide some information |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #21994 +/- ##
==========================================
+ Coverage 45.36% 46.48% +1.11%
==========================================
Files 244 253 +9
Lines 13333 14238 +905
Branches 2719 2925 +206
==========================================
+ Hits 6049 6618 +569
- Misses 6983 7267 +284
- Partials 301 353 +52
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Co-authored-by: Copilot <[email protected]> Signed-off-by: miner <[email protected]>
Hi @OrlinVasilev, Thanks for the comment and This is not a functionality change and only for improving the test case when there's some network stability issue in some circumstance. I would add inline comments in the code. |
wy65701436
pushed a commit
to wy65701436/harbor
that referenced
this pull request
May 16, 2025
* increase docker client timeout for robot case Signed-off-by: my036811 <[email protected]> Signed-off-by: miner <[email protected]>
OrlinVasilev
pushed a commit
to OrlinVasilev/harbor
that referenced
this pull request
Oct 29, 2025
* increase docker client timeout for robot case Signed-off-by: my036811 <[email protected]> Signed-off-by: miner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to Harbor!
Comprehensive Summary of your change
Issue being fixed
Fixes #(issue)
Please indicate you've done the following: