feat: add rate limiter for alibaba cloud acr adapter #21953
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
njucjc
force-pushed
the
add_rate_limiter
branch
from
34a2a32 to
7a6c37e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #21953 +/- ##
==========================================
+ Coverage 45.36% 46.49% +1.12%
==========================================
Files 244 253 +9
Lines 13333 14238 +905
Branches 2719 2925 +206
==========================================
+ Hits 6049 6620 +571
- Misses 6983 7263 +280
- Partials 301 355 +54
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
chlins
added
release-note/update
chlins
reviewed
May 8, 2025
chlins
reviewed
May 13, 2025
|
I suggest the |
njucjc
force-pushed
the
add_rate_limiter
branch
4 times, most recently
from
0a76d2d to
bcee0d1
Compare
chlins
reviewed
May 15, 2025
chlins
reviewed
May 15, 2025
njucjc
force-pushed
the
add_rate_limiter
branch
2 times, most recently
from
bf35cdb to
3899f1b
Compare
|
@wy65701436 PTAL |
wy65701436
reviewed
May 27, 2025
chlins
reviewed
May 27, 2025
| var envTcrQPSLimit, _ = strconv.Atoi(os.Getenv("TCR_QPS_LIMIT")) | ||
| if envTcrQPSLimit > 1 && envTcrQPSLimit < tcrQPSLimit { | ||
| tcrQPSLimit = envTcrQPSLimit | ||
| var envTcrQPSLimit, _ = strconv.Atoi(os.Getenv("REG_ADAPTER_TCR_QPS_LIMIT")) |
There was a problem hiding this comment.
@kofj Please take a look, because as this refactor, the env key of rate limit for TCR has been changed.
Signed-off-by: njucjc <[email protected]>
OrlinVasilev
pushed a commit
to OrlinVasilev/harbor
that referenced
this pull request
Oct 29, 2025
Signed-off-by: njucjc <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to Harbor!
Comprehensive Summary of your change
Add rate limiter for Alibaba Cloud ACR adapter
Please indicate you've done the following: