Skip to content

Conversation

@wy65701436
Copy link
Contributor

Make the golang version as a unified parameter to build all harbor components

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Make the golang version as a unified parameter to build all harbor components

Signed-off-by: wang yan <[email protected]>
@wy65701436 wy65701436 requested a review from a team as a code owner April 25, 2025 11:47
@codecov
Copy link

codecov bot commented Apr 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.45%. Comparing base (c8c11b4) to head (9e1510f).
Report is 467 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #21935      +/-   ##
==========================================
+ Coverage   45.36%   46.45%   +1.08%     
==========================================
  Files         244      253       +9     
  Lines       13333    14236     +903     
  Branches     2719     2925     +206     
==========================================
+ Hits         6049     6613     +564     
- Misses       6983     7273     +290     
- Partials      301      350      +49     
Flag Coverage Δ
unittests 46.45% <ø> (+1.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 178 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wy65701436 wy65701436 merged commit b3cfe22 into goharbor:main Apr 27, 2025
13 of 14 checks passed
wy65701436 added a commit to wy65701436/harbor that referenced this pull request May 16, 2025
Make the golang version as a unified parameter to build all harbor components

Signed-off-by: wang yan <[email protected]>
OrlinVasilev pushed a commit to OrlinVasilev/harbor that referenced this pull request Oct 29, 2025
Make the golang version as a unified parameter to build all harbor components

Signed-off-by: wang yan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-note/update Update or Fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants