Skip to content

Conversation

@liubin
Copy link
Contributor

@liubin liubin commented Apr 15, 2025

copyBlobByChunk() should like copyBlob(), first try to mount an exists layer, if not mounted or exist, then copy the layer monolithic or by chunks.

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@liubin liubin requested a review from a team as a code owner April 15, 2025 12:52
@codecov
Copy link

codecov bot commented Apr 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.47%. Comparing base (c8c11b4) to head (7e434f7).
Report is 460 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #21883      +/-   ##
==========================================
+ Coverage   45.36%   46.47%   +1.10%     
==========================================
  Files         244      253       +9     
  Lines       13333    14233     +900     
  Branches     2719     2924     +205     
==========================================
+ Hits         6049     6615     +566     
- Misses       6983     7267     +284     
- Partials      301      351      +50     
Flag Coverage Δ
unittests 46.47% <ø> (+1.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 178 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@chlins chlins added the release-note/update Update or Fix label Apr 15, 2025
Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@liubin liubin changed the title fix: avoid copying layers size samller than chunk size fix: check blob exist before copying layers samller than chunk size Apr 18, 2025
`copyBlobByChunk()` should like `copyBlob()`, first try to mount an
exists layer, if not mounted or exist, then copy the layer monolithic
or by chunks.

Signed-off-by: Bin Liu <[email protected]>
Signed-off-by: Bin Liu <[email protected]>
@liubin liubin force-pushed the fix-avoid-copying-layers-smaller-than-chucnk-size branch from 93889b3 to d701d88 Compare April 18, 2025 08:08
Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wy65701436 wy65701436 enabled auto-merge (squash) April 21, 2025 07:32
@wy65701436 wy65701436 merged commit 6772477 into goharbor:main Apr 21, 2025
12 checks passed
wy65701436 pushed a commit to wy65701436/harbor that referenced this pull request May 16, 2025
…oharbor#21883)

`copyBlobByChunk()` should like `copyBlob()`, first try to mount an
exists layer, if not mounted or exist, then copy the layer monolithic
or by chunks.

Signed-off-by: Bin Liu <[email protected]>
Signed-off-by: Bin Liu <[email protected]>
OrlinVasilev pushed a commit to OrlinVasilev/harbor that referenced this pull request Oct 29, 2025
…oharbor#21883)

`copyBlobByChunk()` should like `copyBlob()`, first try to mount an
exists layer, if not mounted or exist, then copy the layer monolithic
or by chunks.

Signed-off-by: Bin Liu <[email protected]>
Signed-off-by: Bin Liu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-note/update Update or Fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants