-
Notifications
You must be signed in to change notification settings - Fork 5k
fix: check blob exist before copying layers samller than chunk size #21883
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: check blob exist before copying layers samller than chunk size #21883
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #21883 +/- ##
==========================================
+ Coverage 45.36% 46.47% +1.10%
==========================================
Files 244 253 +9
Lines 13333 14233 +900
Branches 2719 2924 +205
==========================================
+ Hits 6049 6615 +566
- Misses 6983 7267 +284
- Partials 301 351 +50
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
`copyBlobByChunk()` should like `copyBlob()`, first try to mount an exists layer, if not mounted or exist, then copy the layer monolithic or by chunks. Signed-off-by: Bin Liu <[email protected]> Signed-off-by: Bin Liu <[email protected]>
93889b3 to
d701d88
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
…oharbor#21883) `copyBlobByChunk()` should like `copyBlob()`, first try to mount an exists layer, if not mounted or exist, then copy the layer monolithic or by chunks. Signed-off-by: Bin Liu <[email protected]> Signed-off-by: Bin Liu <[email protected]>
…oharbor#21883) `copyBlobByChunk()` should like `copyBlob()`, first try to mount an exists layer, if not mounted or exist, then copy the layer monolithic or by chunks. Signed-off-by: Bin Liu <[email protected]> Signed-off-by: Bin Liu <[email protected]>
copyBlobByChunk()should likecopyBlob(), first try to mount an exists layer, if not mounted or exist, then copy the layer monolithic or by chunks.Thank you for contributing to Harbor!
Comprehensive Summary of your change
Issue being fixed
Fixes #(issue)
Please indicate you've done the following: