Skip to content

Conversation

@BeryJu
Copy link
Member

@BeryJu BeryJu commented Jan 29, 2026

closes #19794

previously we implicitly used pydantic's EmailStr for email address validation, which has different rules than Django does, and as such you could have a broken SCIM sync if a user had an email that django considered valid but pydantic didn't.

@BeryJu BeryJu requested a review from a team as a code owner January 29, 2026 15:24
@BeryJu BeryJu added area:backend backport/version-2025.12 Add this label to PRs to backport changes to version-2025.12 labels Jan 29, 2026
@netlify
Copy link

netlify bot commented Jan 29, 2026

Deploy Preview for authentik-docs ready!

Name Link
🔨 Latest commit 8ebe4ea
🔍 Latest deploy log https://app.netlify.com/projects/authentik-docs/deploys/697b7bc9f5035d00089d2923
😎 Deploy Preview https://deploy-preview-19848--authentik-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov
Copy link

codecov bot commented Jan 29, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.25%. Comparing base (fd209ee) to head (f6ad4ef).
⚠️ Report is 2 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #19848   +/-   ##
=======================================
  Coverage   93.24%   93.25%           
=======================================
  Files         965      966    +1     
  Lines       53196    53221   +25     
=======================================
+ Hits        49603    49630   +27     
+ Misses       3593     3591    -2     
Flag Coverage Δ
conformance 38.14% <51.72%> (+<0.01%) ⬆️
e2e 44.15% <62.06%> (-0.01%) ⬇️
integration 22.95% <0.00%> (-0.01%) ⬇️
unit 91.40% <100.00%> (+<0.01%) ⬆️
unit-migrate 91.43% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Jens Langhammer <[email protected]>
@BeryJu BeryJu merged commit 9570de2 into main Jan 29, 2026
97 checks passed
@BeryJu BeryJu deleted the providers/scim/fix-email-validation-missmatch branch January 29, 2026 16:24
authentik-automation bot pushed a commit that referenced this pull request Jan 29, 2026
* providers/scim: fix email validation mismatch

Signed-off-by: Jens Langhammer <[email protected]>

* fix wrong type of email

Signed-off-by: Jens Langhammer <[email protected]>

---------

Signed-off-by: Jens Langhammer <[email protected]>
@authentik-automation
Copy link
Contributor

🍒 Cherry-pick to version-2025.12 created: #19853

@github-actions
Copy link
Contributor

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-f6ad4ef787d1a6368ba611a687cead393b8c7816
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
    image:
        repository: ghcr.io/goauthentik/dev-server
        tag: gh-f6ad4ef787d1a6368ba611a687cead393b8c7816

Afterwards, run the upgrade commands from the latest release notes.

BeryJu added a commit that referenced this pull request Jan 29, 2026
…version-2025.12) (#19853)

providers/scim: fix email validation mismatch (#19848)

* providers/scim: fix email validation mismatch



* fix wrong type of email



---------

Signed-off-by: Jens Langhammer <[email protected]>
Co-authored-by: Jens L. <[email protected]>
kensternberg-authentik added a commit that referenced this pull request Jan 31, 2026
* main: (52 commits)
  website: QL Search keyboard interactions docs, examples. (#16259)
  website/integrations: immich: add signing algorithm (#19187)
  website/docs: endpoint devices: add version command (#19767)
  common: introduce common (#19852)
  web: bump @sentry/browser from 10.37.0 to 10.38.0 in /web in the sentry group across 1 directory (#19871)
  core: bump debugpy from 1.8.19 to 1.8.20 (#19872)
  ci: bump actions/cache from 5.0.2 to 5.0.3 (#19873)
  web: bump chromedriver from 144.0.1 to 145.0.0 in /web (#19874)
  web: Captcha Refinements, Part 2  (#19757)
  root: assign cherry-pick PRs to original author (#19858)
  web: Lit Development Mode, performance fixes. (#19825)
  web: Fix development theme overrides (#19826)
  website/docs: add tip for recovering from accidental main branch work (#19865)
  web: bump API Client version (#19857)
  rbac: clean up roles and permissions (#19588)
  web: bump API Client version (#19851)
  website/docs: add more info to entra id scim doc (#19849)
  sources/oauth: Fix an issue where wechat may crash duing login. (#18973)
  providers/scim: fix email validation mismatch (#19848)
  providers/scim: modify user- and group syncing behavior (#13947)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:backend backport/version-2025.12 Add this label to PRs to backport changes to version-2025.12

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SCIM sync is completely stopped due to restricted domain at a user email

1 participant