This repository was archived by the owner on Apr 1, 2025. It is now read-only.
remove unreachable code to avoid 'go vet' warnings #181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Contributor
|
Is it possible to get this merged? |
Contributor
|
@mogthesprog Why do we need the additional go get call in travis? |
Contributor
|
I hadn't noticed that. I'm pretty sure it's not needed at all. I can raise another PR without that change in it? |
Contributor
|
@mogthesprog Yes.. #173 was exactly that, but unfortunately it got removed after this PR. Happy to merge if you can redo it. |
Contributor
|
Sure, no worries. Bear with me a sec.. |
Contributor
|
Sorted out in #249. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
same as #173 with additional change in .travis.yaml to fix the build