fix(task): require explicit confirmation before saving reminders#2212
Draft
fix(task): require explicit confirmation before saving reminders#2212
Conversation
Prevent reminders from being saved to the API until the user clicks Confirm, matching the behavior of the due/start/end date pickers. - Remove @update:modelValue handler on DatepickerInline so date/time changes only update local state - Change Confirm button condition from showFormSwitch to activeForm so it renders even when defaultRelativeTo is null - Add confirmAndClose function that handles both absolute and relative reminder forms - Remove debounce (useDebounceFn) since saves are now user-initiated Refs #2208
- Test that clicking a date in the absolute reminder picker does not auto-save, only saves when Confirm is clicked - Test that the Confirm button is visible when task has no due date (defaultRelativeTo is null) Refs #2208
Member
Author
|
auggie review |
🤖 Augment PR SummarySummary: This PR updates the task reminder UI so absolute date/time reminders are only saved after explicit confirmation, keeping the popup open long enough to adjust the time. Changes:
🤖 Was this summary useful? React with 👍 or 👎 |
![augmentcode[bot]](https://avatars.githubusercontent.com/in/1027498?s=60&v=4){kind=small}
… selection The DatepickerInline quick-select buttons (Tomorrow, etc.) inside the reminder popup no longer auto-save. Update existing tests to click Confirm after selecting a date. Refs #2208
…e reminder picker Prevents emitting a reminder with reminder=null/relativeTo=null when the user clicks Confirm without selecting a date first. Refs #2208
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the reminder popup closes right after clicking on a date. This prevents users from actually setting a reminder time - they have to edit the reminder after adding it.
This PR changes that: Reminders are now not saved when clicking on the date, requiring users to click on the button below the time input to save the reminder.
Resolves #2208