Skip to content

refactor: drop duplicate executor.DestroyBuild call #313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 19, 2022
Merged

refactor: drop duplicate executor.DestroyBuild call #313

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3eecfba
refactor: drop duplicate executor.DestroyBuild call
cognifloyd Apr 14, 2022
99d081a
Merge branch 'master' into drop-duplicate-destroybuild
wass3r Apr 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 2 additions & 9 deletions cmd/vela-worker/exec.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,8 @@ func (w *Worker) exec(index int) error {
if err != nil {
logger.Errorf("unable to destroy build: %v", err)
}

logger.Info("completed build")
}()

logger.Info("creating build")
Expand Down Expand Up @@ -142,14 +144,5 @@ func (w *Worker) exec(index int) error {
return nil
}

logger.Info("destroying build")
// destroy the build with the executor
err = _executor.DestroyBuild(context.Background())
if err != nil {
logger.Errorf("unable to destroy build: %v", err)
}

logger.Info("completed build")

return nil
}