feat: worker auth endpoints #212
Conversation
Codecov Report
@@ Coverage Diff @@
## main #212 +/- ##
==========================================
+ Coverage 90.75% 91.42% +0.66%
==========================================
Files 18 18
Lines 1331 1365 +34
==========================================
+ Hits 1208 1248 +40
+ Misses 91 87 -4
+ Partials 32 30 -2
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
cognifloyd
left a comment
cognifloyd
left a comment
There was a problem hiding this comment.
LGTM. I have one question about why we need some functions, but that doesn't block merging this.
| fmt.Printf("Received response code %d, for worker %+v", resp.StatusCode, worker) | ||
| } | ||
|
|
||
| func ExampleWorkerService_RefreshAuth() { |
There was a problem hiding this comment.
Where is this used? Same goes for the rest of the ExampleWorkerService_* funcs.
There was a problem hiding this comment.
honestly im not sure. i added it for consistency
There was a problem hiding this comment.
seemed like leftover boiler plate tests from the initial worker router commits. we can probably remove them in favor the more detailed tests above them
There was a problem hiding this comment.
this is used for documentation, see https://pkg.go.dev/github.com/go-vela/[email protected]/vela#example-WorkerService.Update as an example (no pun intended) which is extracted from ExampleWorkerService_Update
There was a problem hiding this comment.
oh!!! 😮💨 thats awesome. i didnt know go doc used test naming to populate that. thanks @wass3rw3rk
this adds the server functionality introduced in go-vela/server#790
it also cleans up a couple tests