Conversation
…callback also add tests and examples for cross-poll data passing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the issue of multiple pools communicating directly with each other. It was possible to communicate safely via
Collector, but this is a cumbersome way and not really what the collector is for (i.e., to collect the final result in a thread-safe way).A much simpler flow would be if one pool worker could send data to another pool directly (see examples/direct_chain). However, to make this possible, two changes are required:
Submitis not safe for such usage as it is optimized for speed, and in a typical use case, a single producer does the submissions. To address this limitation, the newSendmethod was added, which is essentially the same asSubmitwrapped with a mutex.Additionally, a bunch of tests and a new example for pool-to-pool chain flow have been added.