Conversation
…s in batch mode cancellation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR is a result of benchmarking the pool performance against typical approaches: errgroup and a manual pool of goroutines with a channel. After checking it, I have made several changes:
The end result is not bad: the pool performs better compared to same-sized errgroup or manual pool in any tested cases. Pls note: the traditional (manual) pool showed results almost identical to errgroup
Key observations:
Batching with size 100 provides the most significant improvement, more than doubling performance compared to errgroup.
The results suggest that batching is the most significant performance optimization, while chunking adds functionality (predictable distribution) without significant performance impact.