Merged
Conversation
Add database roundtrip tests against MariaDB for all exported format types, exercising the sql.Scanner/driver.Valuer interfaces. Split integration tests into per-database sub-packages (mariadb/, mongodb/) so that tests mutating package-level globals like MarshalFormat cannot interfere with each other. Document the DateTime/MySQL incompatibility (issue go-openapi#174) in both the test and README, including the MarshalFormat workaround. Also: add MariaDB service to CI workflow, disable gomoddirectives linter (needed for local replace in monorepo setup), fix unused parameter lint in mongo_test.go. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
…on tests Add PostgreSQL integration test package with 27 tests covering all strfmt types. PostgreSQL handles RFC3339 DateTime natively (no issue go-openapi#174 workaround needed). Refactor MariaDB and MongoDB tests to use go-openapi/testify/v2. Update CI workflow with PostgreSQL service container. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #220 +/- ##
=======================================
Coverage 85.01% 85.01%
=======================================
Files 14 14
Lines 2016 2016
=======================================
Hits 1714 1714
Misses 218 218
Partials 84 84 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change type
Please select: 🆕 New feature or enhancement|🔧 Bug fix'|📃 Documentation update
Short description
Fixes
Full description
Checklist